[Ffmpeg-devel-irc] ffmpeg-devel.log.20111203

[burek]

[00:24] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * rb552e3f6d8 10ffmpeg/libswscale/swscale.c: 
[00:24] <CIA-41> ffmpeg: swscale: Fix all cast qualifier warnings:
[00:24] <CIA-41> ffmpeg: libswscale/swscale.c:2744:40: warning: to be safe all intermediate pointers in cast from int16_t ** to const int16_t ** must be const qualified [-Wcast-qual]
[00:24] <CIA-41> ffmpeg: libswscale/swscale.c:2745:41: warning: to be safe all intermediate pointers in cast from int16_t ** to const int16_t ** must be const qualified [-Wcast-qual]
[00:24] <CIA-41> ffmpeg: libswscale/swscale.c:2746:41: warning: to be safe all intermediate pointers in cast from int16_t ** to const int16_t ** must be const qualified [-Wcast-qual]
[00:24] <CIA-41> ffmpeg: libswscale/swscale.c:2747:78: warning: to be safe all intermediate pointers in cast from int16_t ** to const int16_t ** must be const qualified [-Wcast-qual]
[00:24] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[00:24] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * r3fd4fe0e03 10ffmpeg/libswscale/x86/swscale_mmx.c: 
[00:24] <CIA-41> ffmpeg: swscale_mmx: Fix cast qualifier warnings:
[00:24] <CIA-41> ffmpeg: libswscale/x86/swscale_mmx.c:131:36: warning: to be safe all intermediate pointers in cast from int16_t ** to const int16_t ** must be const qualified [-Wcast-qual]
[00:24] <CIA-41> ffmpeg: libswscale/x86/swscale_mmx.c:132:37: warning: to be safe all intermediate pointers in cast from int16_t ** to const int16_t ** must be const qualified [-Wcast-qual]
[00:24] <CIA-41> ffmpeg: libswscale/x86/swscale_mmx.c:133:74: warning: to be safe all intermediate pointers in cast from int16_t ** to const int16_t ** must be const qualified [-Wcast-qual]
[00:24] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[00:24] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * ra24c4758d5 10ffmpeg/libswscale/x86/swscale_template.c: 
[00:25] <CIA-41> ffmpeg: sws: remove unused variable
[00:25] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[00:36] <CIA-41> ffmpeg: 03Giorgio Vazzana 07master * r208bcc6b5b 10ffmpeg/libavutil/samplefmt.c: 
[00:36] <CIA-41> ffmpeg: libavutil: increase struct SampleFmtInfo member 'name' length to 8
[00:36] <CIA-41> ffmpeg: This is necessary since some sample format names are longer than 3 characters.
[00:36] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[00:55] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * rebe4d5adc5 10ffmpeg/libswresample/swresample_test.c: 
[00:55] <CIA-41> ffmpeg: swr-test_: Fix mixed declaration and statements:
[00:55] <CIA-41> ffmpeg: swresample_test.c:123:21: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
[00:55] <CIA-41> ffmpeg: swresample_test.c:127:25: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
[00:55] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[00:55] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * r12804348f5 10ffmpeg/libswresample/swresample_test.c: 
[00:55] <CIA-41> ffmpeg: swr-test: drop one const, silence most const qualifer warnings.
[00:55] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[03:13] <CIA-41> ffmpeg: 03John Stebbins 07master * rb88eb87630 10ffmpeg/libavformat/asfdec.c: 
[03:13] <CIA-41> ffmpeg: asf: use packet dts as approximation of pts
[03:13] <CIA-41> ffmpeg: Having a somehow off seeking is better than having none at all.
[03:13] <CIA-41> ffmpeg: Signed-off-by: Luca Barbato <lu_zero at gentoo.org>
[03:13] <CIA-41> ffmpeg: 03Luca Barbato 07master * r73f027c17b 10ffmpeg/libavformat/asfdec.c: 
[03:13] <CIA-41> ffmpeg: asf: do not call av_read_frame
[03:13] <CIA-41> ffmpeg: The asf_read_pts should read the bitstream directly.
[03:13] <CIA-41> ffmpeg: 03Nathan Adil Maxson 07master * rd0fd6fc201 10ffmpeg/libavcodec/alacenc.c: 
[03:13] <CIA-41> ffmpeg: Cleaned up alacenc.c
[03:13] <CIA-41> ffmpeg: Signed-off-by: Ronald S. Bultje <rsbultje at gmail.com>
[03:13] <CIA-41> ffmpeg: 03Martin Storsjö 07master * r30266038bd 10ffmpeg/libavformat/rtsp.c: (log message trimmed)
[03:13] <CIA-41> ffmpeg: rtsp: Initialize the media_type_mask in the rtp guessing demuxer
[03:13] <CIA-41> ffmpeg: The media_type_mask is initialized via AVOptions for the
[03:13] <CIA-41> ffmpeg: rtsp and sdp demuxers, but it isn't available as an option
[03:13] <CIA-41> ffmpeg: for the rtp guessing demuxer (since it doesn't really make
[03:13] <CIA-41> ffmpeg: sense there). Therefore, it must be manually initialized
[03:13] <CIA-41> ffmpeg: instead, since a zero value means no media types at all
[03:13] <CIA-41> ffmpeg: 03Aaron Colwell 07master * re02dec25ab 10ffmpeg/libavcodec/vp8.c: vp8: flush buffers on size changes.
[03:13] <CIA-41> ffmpeg: 03Mans Rullgard 07master * r150ddbc148 10ffmpeg/ (avconv.c libavformat/nullenc.c): (log message trimmed)
[03:13] <CIA-41> ffmpeg: Do not memcpy raw video frames when using null muxer
[03:13] <CIA-41> ffmpeg: Commit 035af99 made avconv always call an encoder when using the
[03:13] <CIA-41> ffmpeg: null muxer. While useful for 2-pass encodes, it inadvertently
[03:13] <CIA-41> ffmpeg: caused an extra memcpy of raw frames when decoding only.
[03:13] <CIA-41> ffmpeg: This hack restores the old behaviour when only decoding while
[03:13] <CIA-41> ffmpeg: allowing use of the null muxer with encoded streams as well.
[03:13] <CIA-41> ffmpeg: 03Mans Rullgard 07master * r59807fee6d 10ffmpeg/libavcodec/arm/h264dsp_neon.S: 
[03:13] <CIA-41> ffmpeg: ARM: h264dsp_neon cosmetics
[03:13] <CIA-41> ffmpeg: - Replace 'ip' with 'r12'.
[03:13] <CIA-41> ffmpeg: - Use correct size designators for vld1/vst1.
[03:13] <CIA-41> ffmpeg: - Whitespace fixes.
[03:13] <CIA-41> ffmpeg: Signed-off-by: Mans Rullgard <mans at mansr.com>
[03:13] <CIA-41> ffmpeg: 03Janne Grunau 07master * ra760f530bb 10ffmpeg/libavcodec/arm/ (h264dsp_neon.S neon.S vp8dsp_neon.S): 
[03:13] <CIA-41> (43 lines omitted)
[03:27] <CIA-41> ffmpeg: 03Clément BSsch 07master * r215b7724e7 10ffmpeg/ (18 files in 2 dirs): lavf: rename remaining av_set_pts_info() to avpriv_set_pts_info().
[03:35] <CIA-41> ffmpeg: 03Carl Eugen Hoyos 07master * r2d6a45c12a 10ffmpeg/libavcodec/ (h264.c h264_parser.c): 
[03:35] <CIA-41> ffmpeg: Silence warnings when decoding QNAP Systems H264 codec.
[03:35] <CIA-41> ffmpeg: Fixes ticket #571.
[03:47] <CIA-41> ffmpeg: 03Peter Ross 07master * r56f6628bca 10ffmpeg/libavcodec/pictordec.c: 
[03:47] <CIA-41> ffmpeg: pictordec: decode 8bpp images when extra header marker is missing
[03:47] <CIA-41> ffmpeg: Fixes ticket #696.
[03:47] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[03:47] <CIA-41> ffmpeg: 03Peter Ross 07master * r52b7ed4f6e 10ffmpeg/libavcodec/iff.c: 
[03:47] <CIA-41> ffmpeg: iff: support ExtraHalfBrite (EHB) palette mode
[03:47] <CIA-41> ffmpeg: Fixes ticket #663.
[03:47] <CIA-41> ffmpeg: Based on patch by ami_stuff
[03:47] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[03:47] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * racf22ec69e 10ffmpeg/doc/developer.texi: 
[03:47] <CIA-41> ffmpeg: developer.texi: Fix naming convention
[03:47] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[04:50] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * r3eb6e14618 10ffmpeg/libavcodec/zmbv.c: 
[04:50] <CIA-41> ffmpeg: zmbv: Fix keyframe fault protextion.
[04:50] <CIA-41> ffmpeg: Fixes zzuf -s467 -r0.001 cat samples/zmbv/wc2_001-partial.avi
[04:50] <CIA-41> ffmpeg: Bug-found-by: darkshikari
[04:50] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[04:51] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * r7a5eb40ea1 10ffmpeg/libavcodec/utils.c: 
[04:51] <CIA-41> ffmpeg: audeo_get_buffer: fix pkt_pos
[04:51] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[05:35] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * r8bd2b27f6b 10ffmpeg/libavcodec/zmbv.c: 
[05:35] <CIA-41> ffmpeg: zmbv: fix 2 memleaks
[05:35] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[05:35] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * ra930cd0d19 10ffmpeg/libavformat/oma.c: 
[05:35] <CIA-41> ffmpeg: oma: Fix out of array read.
[05:35] <CIA-41> ffmpeg: Input: 01-Untitled-partial.oma
[05:35] <CIA-41> ffmpeg: ZZUF params: zzuf[s=7157,r=0.001]
[05:35] <CIA-41> ffmpeg: Bug-found-by: darkshikari
[05:35] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[05:35] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * raedd30b63a 10ffmpeg/libavformat/id3v2.c: 
[05:35] <CIA-41> ffmpeg: id3v2: Fix null ptr crash in get_extra_meta_func()
[05:35] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[11:24] <ago> Hi folks!
[11:25] <ago> Usually, every ffmpeg vulnerabilities, there are CVE assigned to them, so for the vulnerabilities reported in < of 0.7.7 ( https://secunia.com/advisories/46736/ ) there are no specified vulnerabilities.
[11:26] <ago> So, we can't ask a CVE, can you please explain the issue so we can ask every CVE for every issue?
[11:26] <ago> thanks in advance
[11:28] <ago> If them were already assigned, please point me them, because I didn't see anything on secunia and oss-security
[12:05] <CIA-41> ffmpeg: 03Nicolas George 07master * r90bfd511c4 10ffmpeg/libavcodec/libcelt_dec.c: 
[12:05] <CIA-41> ffmpeg: celtdec: adapt to avcodec_decode_audio4.
[12:05] <CIA-41> ffmpeg: Original fix by Michael Niedermayer.
[12:05] <CIA-41> ffmpeg: Slightly modified to avoid the now redundant multiplications
[12:05] <CIA-41> ffmpeg: and divisions in the main code path.
[12:38] <CIA-41> ffmpeg: 03Carl Eugen Hoyos 07master * r88bbabcc00 10ffmpeg/libavcodec/targa.c: 
[12:38] <CIA-41> ffmpeg: Support decoding right-to-left targa files.
[12:38] <CIA-41> ffmpeg: Fixes ticket #698.
[12:38] <CIA-41> ffmpeg: 03Carl Eugen Hoyos 07master * r8dcd2a41ec 10ffmpeg/libavformat/mov.c: 
[12:38] <CIA-41> ffmpeg: Allow last mov chunk to have an arbitrary number of samples.
[12:38] <CIA-41> ffmpeg: Fixes ticket #673.
[12:38] <CIA-41> ffmpeg: 03ami_stuff 07master * r28a11a67d2 10ffmpeg/libavcodec/bmp.c: 
[12:38] <CIA-41> ffmpeg: BMP: Support BMP OS/2 v2 with RLE compression.
[12:38] <CIA-41> ffmpeg: Fixes ticket #699.
[12:38] <CIA-41> ffmpeg: Patch also provided by Peter Ross.
[15:15] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * r730945d941 10ffmpeg/ffmpeg.c: 
[15:15] <CIA-41> ffmpeg: ffmpeg: use standard duration calculation code in the stream copy case.
[15:15] <CIA-41> ffmpeg: Fixes a.mkv non monotonic timestamps
[15:15] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[15:33] <ubitux> the SBG decoder looks very fun :)
[15:34] <ubitux> but i still have no clue how to save & git am the whole patchset quickly with mutt :(
[15:34] <Compn> git should tie into it
[15:35] <Compn> you should be able to hit one key to auto patch it 
[15:35] <Compn> how to set that up i have no idea
[15:36] <ubitux> :(
[15:37] <Compn> lesset
[15:37] <Compn> er 
[15:38] <Compn> http://blog.ndrix.com/2007/05/mutt-and-git-format-patch.html
[15:39] <Compn> or this maybe http://flavioleitner.blogspot.com/2011/03/patch-workflow-with-mutt-and-git.html
[15:44] <ubitux> mmh thx i'll check this out
[15:56] <CIA-41> ffmpeg: 03Nicolas George 07master * r757cb3b46a 10ffmpeg/libavutil/avutil.h: (log message trimmed)
[15:56] <CIA-41> ffmpeg: avutil: av_x_if_null: remove const for the return value.
[15:56] <CIA-41> ffmpeg: This is the usual weirdness with const/non-const pointers through a function.
[15:56] <CIA-41> ffmpeg: See the prototype of strchr for a standard example.
[15:56] <CIA-41> ffmpeg: The function had to be moved down, below the point where stdint.h is
[15:56] <CIA-41> ffmpeg: indirectly included.
[15:56] <CIA-41> ffmpeg: Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
[15:56] <CIA-41> ffmpeg: 03Nicolas George 07master * r976b095939 10ffmpeg/ (4 files in 2 dirs): 
[15:56] <CIA-41> ffmpeg: lavu/error: define AVERROR_BUG.
[15:56] <CIA-41> ffmpeg: Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
[15:56] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[17:16] <ubitux> i think i'm happy not to have much GCI students messing with the code on ffmpeg-devel =)
[17:17] <ubitux> it looks exhausting to review there re-styling patches :p
[17:34] <Compn> i hope they are testing benchmarks :P
[17:34] <Compn> mpegvideo.c review
[17:34] <Compn> lol
[17:54] <michaelni> mpegvideo.c "review", ROTFL
[17:54] <michaelni> more correctly, human indent program
[18:19] <Daemon404> nothing wrong with having a consistent coding style <.<
[18:20] <Daemon404> not too sure why it's a gci task tho
[18:34] <JEEB> Because no-one really wants to clean up stuff >_>
[18:34] <JEEB> it's not a "rewarding" task
[18:34] <JEEB> you can see it in a certain media player's renderer fixage branch as well
[18:35] <JEEB> the developer likes to do new stuff, but nothing gets finished
[18:35] <JEEB> because the reward for actually getting something to "work" for the first time is bigger than to fix it completely
[18:39] <JEEB> oh, and not to mention that in most cases the debugging to find the cause(s) for problems adds the need for effort
[18:39] <j-b> Daemon404: because it is a good way to have people not being afraid of opening the code and compiling it
[18:39] <j-b> which is what GCi is about
[18:40] <Daemon404> true enough
[18:40] <JEEB> yeah, and that too
[18:41] <Daemon404> j-b, mind you, tha majority of work can be aided by a couple nifty regex
[18:41] <Daemon404> if you spot patterns
[18:41] <JEEB> I wish there was GCI back when I was in high school :)
[18:41] <j-b> Daemon404: sure. If people had brains
[18:41] <Daemon404> lol
[18:42] <j-b> Daemon404: to the 'remove tabs' task in VLC, i have seen 7 students so far
[18:42] <j-b> only one succeeded
[18:42] <Daemon404> O_o
[18:42] <Daemon404> thats crazy
[18:42] <j-b> one sent a 540MB patch
[18:42] <Daemon404> O______O
[18:42] <j-b> 3 sent a 50MB tarball
[18:42] <j-b> while the source is 200MB with whole git, and tarball is 20MB
[18:43] <j-b> you were saying?
[18:43] <Daemon404> i ... cannot comprehend/
[18:43] <j-b> :)
[18:43] <Daemon404> also, from what i can tell
[18:44] <Daemon404> 90% of time spent in gci is "learn to use git"
[18:45] <j-b> possibly
[19:37] <gnafu> Daemon404: Considering many of the leading open source projects are using or moving to git, and that some of these students may go on to contribute to things other than ffmpeg/libav, learning git is probably more important for them than learning ffmpeg/libav :-).
[19:39] <Daemon404> i agree
[19:39] <Daemon404> :P
[19:39] <gnafu> )^_^(
[19:46] <JEEB> indeed
[20:48] <CIA-41> ffmpeg: 03Reimar Döffinger 07master * r85372f9d57 10ffmpeg/libavcodec/x86/dsputil_yasm.asm: 
[20:48] <CIA-41> ffmpeg: Add forgotten %ifdef HAVE_AVX.
[20:48] <CIA-41> ffmpeg: Fixes compilation with older YASM/NASM versions.
[20:48] <CIA-41> ffmpeg: Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
[22:47] <CIA-41> ffmpeg: 03Michael Niedermayer 07master * rff53c79d0a 10ffmpeg/libavformat/flvdec.c: 
[22:47] <CIA-41> ffmpeg: flvdec: Stop searching for streams once a audio & a video stream has been found
[22:47] <CIA-41> ffmpeg: instead of when the 2nd stream has been found.
[22:47] <CIA-41> ffmpeg: This isnt ideal as we will likely still like before miss a data stream.
[22:47] <CIA-41> ffmpeg: Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
[22:52] <ubitux> gnafu: not only learning git
[22:52] <ubitux> it seems they need to learn how to use the mail too
[22:53] <ubitux> (i'm not saying these are simple things)
[22:53] <ubitux> i think google is wrong with operation like that though
[22:54] <ubitux> <+Daemon404> nothing wrong with having a consistent coding style <.< // if the style is consistent within the file, i think it's okay; but anyway that wasn't my point: using 13-17 years old student for this sounds wrong to me& but well, whatever :)
[22:55] <Daemon404> it seems ot be painful for all parties involved
[22:55] <Daemon404> to*
[23:13] <Compn> i think we spend too much time on what code is indented how
[23:13] <Compn> and not enough time on actually fixing bugs or speeding things up
[23:13] <Compn> but thats just my stupid opinion
[23:13] <Compn> and 'we' being ... people who want to reindent code all day for 6000 commits
[23:17] <ubitux> if the coding style is overall consistent, i think we can agree with some inconsistency between files
[23:17] Action: Daemon404 just submitted a bugfix yesterday :3
[00:00] --- Sun Dec  4 2011