[Ffmpeg-devel-irc] ffmpeg-devel.log.20130415

[burek]

[00:23] <cone-349> ffmpeg.git 03Paul B Mahol 07master:977ee8afd6a7: lavfi/negate: stop calling lut_init() as that function does nothing now
[00:27] <ubitux> it looks like lavfi is going to be pretty decent
[00:31] <durandal11707> huh, for what?
[00:32] <ubitux> for filtering?
[00:32] <ubitux> btw, we really need to put a frame counter (frame id?) in the filter context
[00:32] <durandal11707> only after crossfade, aka real scripting
[00:40] <ubitux> scripting is not needed anymore with the timeline support \o/
[00:58] <ubitux> durandal11707: ping
[00:59] <ubitux> durandal11707: gcc is complaining a lot in lavfi/af_aphaser.c in your planar function template
[01:00] <ubitux> also, the code looks somehow odd
[01:00] <durandal11707> ubitux: link?
[01:01] <ubitux> link of what? the warnings?
[01:01] <ubitux> you don't have gcc?
[01:02] <durandal11707> no
[01:02] <ubitux> http://pastie.org/private/owkbeu1xawn0yftg3zzlmw
[01:03] <ubitux> broken spacing for some reason
[01:03] <ubitux> but you get the point
[01:04] <durandal11707> i dont see how that could happen
[01:05] <durandal11707> just ignore warning, (filter does not run on 0 channels)
[01:07] <saste> ubitux: id is useful for commands
[01:07] <saste> suppose you have several volume, and you want to send a command to a specific volume
[01:08] <saste> you can use the automatic name (parsed_volume_3) but that's not very robust
[01:08] <ubitux> saste: why do you tell me that?
[01:08] <ubitux> durandal11707: do you mind if i add a av_assert0(channels > 0); in the function?
[01:08] <ubitux> it makes gcc silent
[01:09] <saste> ubitux: oh i misread this "btw, we really need to put a frame counter (frame id?) in the filter context"
[01:09] <saste> frame id -> filter id
[01:10] <ubitux> a frame counter in each avfilterlink would be perfect
[01:10] <ubitux> the filter updates the counter every time it sees a frame
[01:10] <ubitux> and we can use it in several filters
[01:11] <ubitux> well, the *internals* update the counter
[01:11] <durandal11707> ubitux: you can initialize them to 0
[01:11] <ubitux> durandal11707: i prefer the assert0 :)
[01:12] <durandal11707> that makes code slow by several cycles
[01:12] <ubitux> it's a if it's once per frame...
[01:14] <ubitux> you really think it makes a difference?
[01:18] <ubitux> durandal11707: i'll commit in a moment unless you object
[01:18] <durandal11707> assert1?
[01:19] <ubitux> you seriously think it will affect performances?..
[01:19] <durandal11707> i ignore stupid compiler warnings
[01:19] <ubitux> yes but i don't, because it hides important ones
[01:20] <ubitux> well feel free to revert if the 0.0000001 ns loss are a perf problem for you :P
[01:20] <cone-349> ffmpeg.git 03Clément BSsch 07master:da1bb21c1302: lavfi/aphaser: silence uninitialized variable warnings.
[01:20] <cone-349> ffmpeg.git 03Clément BSsch 07master:e66a10689bf2: lavf/libquvi: fix error reporting.
[01:24] <ubitux> saste: could you retry the libquvi thing when you have time?
[01:26] <ubitux> btw, no comment on the hash tables in dict? :(
[01:32] <cone-349> ffmpeg.git 03Michael Niedermayer 07master:3662e49dde0b: sws: move RGB2YUV_SHIFT to swscale_internal.h
[01:32] <cone-349> ffmpeg.git 03Michael Niedermayer 07master:9aafb95ae230: sws: init input_rgb2yuv_table depending on yuv colorspace
[01:32] <cone-349> ffmpeg.git 03Michael Niedermayer 07master:17ad06c75357: sws/x86: update rgb/bgr->yuv code to use provided coefficient table
[01:32] <cone-349> ffmpeg.git 03Michael Niedermayer 07master:2a5d1cb2d943: sws/x86: update rgba->yuv to use user supplied table
[01:34] <BBB-> ah, rgb2yuv finally isn't 601 only
[01:35] <saste> ubitux: server response code 403 (conncode=0)
[01:36] <ubitux> saste: looks like the server doesn't like you
[01:36] <saste> ubitux, hash tables in dict is a nice idea, didn't look at the patches yet
[01:36] <ubitux> did you try another service?
[01:36] <Compn> vlcs' server doesnt like my browser agent, always get 403 on the forum
[01:37] <saste> ubitux, which other service, i tried with youtube
[01:37] <ubitux> saste: http://pastie.org/7557511  try one of those
[01:37] <ubitux> ted should be a bit less nazi than youtube
[01:38] <ubitux> or maybe just vimeo
[01:38] <ubitux> but all of them regularly break scripts, so it's possible your 0.4.0 doesn't support anymore the new version
[01:39] <saste> /usr/share/libquvi-scripts/lua/website/vimeo.lua:99: server response code 404 (conncode=0)
[01:39] <ubitux> :D
[01:39] <saste> well i'll update the scripts
[01:39] <saste> and retry
[01:58] Action: durandal11707 just finished colorbalance filter
[02:14] <ubitux> michaelni: 
[02:14] <ubitux> libswscale/rgb2rgb.c:108:0: warning: "RGB2YUV_SHIFT" redefined [enabled by default]
[02:14] <ubitux> libswscale/x86/rgb2rgb.c:79:0: warning: "RGB2YUV_SHIFT" redefined [enabled by default]
[02:14] <ubitux> normal?
[02:37] <cone-349> ffmpeg.git 03Michael Niedermayer 07master:8e27c6ebbbab: sws/"rgb2rgb": drop RGB2YUV_SHIFT
[02:43] <durandal11707> i do not know what to do with colorbalance, it looks like its just friendlier but less poverful version of curves
[02:46] <ubitux> keep it simple?
[02:47] <durandal11707> ubitux: its just lut table
[02:47] <durandal11707> eg its same thing that gimp have
[02:47] <ubitux> you added it in vf_lut.c?
[02:48] <durandal11707> no
[02:48] <ubitux> durandal11707: you can do everything the gimp color balance does?
[02:49] <ubitux> like controling shadows/midtones/hilights, preserve luminosity or not, etc?
[02:49] <durandal11707> preserve l is missing, but that is not hard to add
[02:50] <ubitux> can you have presets?
[02:51] <ubitux> also, if you are bored but like the lut, you can add 16-bit support in all the lut filters
[02:51] <ubitux> ...and port vf eq2
[02:51] <ubitux> :)
[02:53] <durandal11707> and to curves too
[02:53] <ubitux> yes, i included it in "all the lut filters"
[02:53] <durandal11707> presets? (gimp have presets for colorbalance?)
[02:53] <ubitux> yes
[02:53] <ubitux> empty by default though
[02:54] <durandal11707> well i dont see how adding presets would help, its just 9 double numbers
[02:55] <ubitux> right
[02:55] <ubitux> then add some presets to curves ;)
[02:55] <durandal11707> ugh, i found page of 28 presets but i need deviantart accunt to download them
[02:56] <durandal11707> channelmixer may be another thing i could pick
[02:56] <ubitux> channelmixer?
[02:56] <ubitux> how is that different from pan?
[02:58] <ubitux> http://onixa.deviantart.com/art/Photoshop-Curves-Pack-121882919
[02:58] <ubitux> 'found this
[02:58] <ubitux> directly downloadable (no need for an account)
[02:58] <ubitux> now i need to get some sense out of these .acv
[02:59] <ubitux> looks like a bunch of 16-bits values
[02:59] <durandal11707> ubitux: channelmixer for video
[02:59] <ubitux> oh
[02:59] <durandal11707> its just lut table
[02:59] <ubitux> ok :)
[03:00] <ubitux> https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/PhotoshopFileFormats.htm#50577411_pgfId-1056330
[03:00] <ubitux> awesome.
[03:00] <durandal11707> they have strange names
[03:00] <ubitux> i wonder if i won't add support for photoshop preset files
[03:00] <ubitux> :D
[03:10] <cone-349> ffmpeg.git 03Michael Niedermayer 07master:a37fd7f9578d: sws: Update rgb24toyv12_c() to user supplied rgb2yuv tables
[03:41] <cone-349> ffmpeg.git 03Michael Niedermayer 07master:920dd84bf1f0: sws/x86: remove 8bit rgb2yuv coefficient case for rgb24toyv12 special converter
[09:04] <cone-986> ffmpeg.git 03Reimar Döffinger 07master:8067f55edf37: Fix compilation on ARM with android gcc 4.7
[09:04] <cone-986> ffmpeg.git 03Reimar Döffinger 07master:c10d498bfd24: Add thread-safe wrapper for get_format().
[11:03] <ubitux> hehe almost done with the support for photoshop preset files for curves :)
[11:11] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:357da7ed4207: sws: remove forgotten FAST_BGR2YV12 define
[11:37] <cone-986> ffmpeg.git 03Clément BSsch 07master:99dac3933916: lavfi/curves: add support for master component.
[11:37] <cone-986> ffmpeg.git 03Clément BSsch 07master:1cb02d4fbc29: lavfi/curves: add support for Photoshop curves files (.acv).
[11:37] <ubitux> :)
[12:15] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:1557f34b10e6: dfa: support decoding version=1.0
[13:24] <ubitux> erm luca wanting to redefine the flv specs
[13:24] <ubitux> :/
[14:44] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:3d8afb23bc9a: vf_deshake: Fix crash with r*=64
[16:32] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:aba678ab9dc6: deshake: fix off by 2 error
[16:37] <durandal_1707> ubitux: your psfile reader does not overread?
[16:39] <ubitux> it should not
[16:56] <durandal_1707> can vf_lut do what levels does?: http://docs.gimp.org/en/gimp-tool-levels.html
[18:04] <cone-986> ffmpeg.git 03Clément BSsch 07master:9ecdd76679e7: lavfi/curves: fix memleak after master component dition.
[18:05] <durandal_1707> typo^
[18:06] <ubitux> meh.
[18:06] <ubitux> it's cute anyway
[18:06] <ubitux> it sounds cute
[18:07] <durandal_1707> enotatall
[18:09] <ubitux> :(
[18:09] <durandal_1707> deband,dering,dehalo
[18:10] <ubitux> frame counter in links done, filters using it done, timeline with frame counter done
[18:10] <ubitux> still need to fix overlay, and then profit.
[18:11] <ubitux> durandal_1707: you like the photoshop preset support?
[18:12] Action: durandal_1707 dont have photoshop
[18:12] Action: ubitux either
[18:12] <ubitux> i actually never used it
[18:12] <cone-986> ffmpeg.git 03Paul B Mahol 07master:77709759797f: lavfi/noise: remove pointless store
[18:13] <ubitux> but all kind of people are sharing bunches of preset like this
[18:18] <cone-986> ffmpeg.git 03Paul B Mahol 07master:8281791d0735: lavfi/histogram: remove pointless store
[18:20] <durandal_1707> so would you like colormixer (aka channelmixer) filter?
[18:22] <ubitux> do you have a use-case, example?
[18:22] <durandal_1707> its same thing you find in gimp/photoshop
[18:23] <durandal_1707> use google
[18:24] <ubitux> what's the name in gimp?
[18:25] <ubitux> color, comp, channel mixer, ok
[18:26] <durandal_1707> should be same
[18:27] <ubitux> well, why not i guess
[18:27] <ubitux> as long as you add fate tests ;)
[18:27] <ubitux> (so at least the fate instance will use it :p)
[18:31] <durandal_1707> will push colorbalance, and leave it for others to fix it
[18:32] <ubitux> durandal_1707: allow me to insist on the usefulness of fate tests when you add a filter
[18:32] <ubitux> it is notably extremely useful when merging or just changing filters, and detecting various valgrind issues (you don't have valgrind, right?)
[18:33] <ubitux> for trivial filters like colorbalance that's relatively simple to do
[18:33] <cone-986> ffmpeg.git 03Paul B Mahol 07master:9e6dd24fa189: doc/filters: move aphaser to right(audio) chapter
[18:34] <durandal_1707> i constantly put documentation into wrong place
[18:35] <ubitux> we should split every filter in a dedicated texi :p
[18:35] <ubitux> and include them in the main one
[18:36] <ubitux> should simplify moving them around, and spotting misplacement
[18:40] <durandal_1707> where i put lavfi tests?
[18:42] <ubitux> depends
[18:42] <ubitux> wherever you prefer
[18:42] <ubitux> filter.mak or avfilter.mak+lavfi-regression.sh
[18:43] <ubitux> filter.mak being the new prefered way
[18:51] <cone-986> ffmpeg.git 03Paul B Mahol 07master:a4f03f082b87: FATE: add a test for the histogram filter
[18:52] <ubitux> overlay finally works, good.
[18:53] <ubitux> timeline finally done
[18:54] <ubitux> durandal_1707: thx :)
[19:11] <ubitux> in a week or two we'll have some nice stories to tell to beastd for a new news entry
[19:11] <ubitux> would be nice to talk a bit about the new features
[19:11] <durandal_1707> no, never ever update this: https://wiki.archlinux.org/index.php/Libavfilter
[19:11] <ubitux> lol wtf
[19:13] <ubitux> archlinux definitely has ffmpeg with lavfi now
[19:13] <ubitux> ffmpeg 1.2 is packaged, with a bunch of nice options
[19:13] <durandal_1707> page shows svn command....
[19:13] <ubitux> yeah
[19:13] <ubitux> :D
[19:35] <durandal_1707> hmm seems some data is left uninitialized
[19:46] <durandal_1707> can it get worse?: https://plus.google.com/109100344291569500053/posts?prsrc=3
[19:52] <ubitux> durandal_1707: haha
[20:32] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:003d497d31ff: pca: use sizeof(variable) instead of sizeos(TYPE)
[20:32] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:8a11114a7908: pca: use av_calloc()
[20:32] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:6e29f39252b9: swr/rematrix: use av_calloc()
[21:12] <ubitux> saste: what do you think about splitting every filter doc in doc/filter/foobar.texi and including them in the main doc?
[21:12] <ubitux> it will avoid some misplacements that often happen
[21:12] <ubitux> and make things simpler to move around
[21:18] <cone-986> ffmpeg.git 03Clément BSsch 07master:34186832de24: doc/filters: add a curves example with psfile.
[21:21] <saste> ubitux, overkill?
[21:21] <ubitux> really?
[21:22] <saste> then you need a script to generate the include list
[21:23] <ubitux> not really.
[21:32] <saste> also how do you organize things so that you preserve the various sections?
[21:32] <saste> also why only filters and not the other components?
[21:34] <ubitux> because we have a lot of filters, so that's where it's problematic
[21:34] <ubitux> but sure we could extend to other as well
[21:34] <ubitux> what do you mean by preserving sections?
[21:39] <saste> ubitux, that we have A/V filters, sinks, buffers, and multimedia filters
[21:40] <saste> also I'm not especially fond of split things
[21:40] <saste> looks for example the split ffmpeg, with three and more different files to grep when looking for stuff
[21:41] <ubitux> yeah the split of ffmpeg was not a good idea
[21:41] <ubitux> well anyway whatever, that was just a random idea
[21:46] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:7a2a421d736c: vf_histogram: avoid floats, unbreak fate
[21:46] <cone-986> ffmpeg.git 03Michael Niedermayer 07master:395023633232: sws/x86: update RENAME(rgb24toyv12)() to using the user provided rgb2yuv table
[21:50] <cone-986> ffmpeg.git 03Clément BSsch 07master:de656ea91e53: lavfi/drawtext: make options array more readable.
[22:14] <saste> ubitux: what's this
[22:14] <saste> (nb & (nb - 1)) == 0)
[22:14] <Tjoppen> saste: looks like a power-of-two test
[22:15] <ubitux> exactly that
[22:15] <ubitux> saste: check the function just above, that's mostly the same
[22:19] <ubitux> i wonder wtf is the eval expr in drawtext expanding is good for
[22:21] <saste> ubitux: pict_type=%{e:pict_type}
[22:21] <ubitux> wut
[22:21] <ubitux> so you can do that? oO
[22:21] <saste> originally added to generalize %{n}
[22:21] <saste> so we can do %{e:n+1} for example
[22:21] <ubitux> oh right, ok
[22:21] <saste> or to print PTS
[22:22] <ubitux> but it's not here yet
[22:22] <ubitux> and well, pict_type as an expressin, i doubt it will work
[22:22] <ubitux> expression*
[22:23] <saste> it's useful for time, dar, etc.
[22:23] <saste> why not?
[22:24] <ubitux> because it's a number
[22:25] <saste> %{pict_type} then
[22:25] <saste> even if I don't know why it's useful
[22:26] <ubitux> checking if the encoder placed appropriate pictures types at scene change maybe
[22:28] <ubitux> well anyway i wanted to use my new awesome string function in drawtext but it will be painful
[22:28] <ubitux> so i guess i'll go for segment then
[22:53] <saste> ubitux: should I ignore this: lavfi/WIP: timeline support?
[22:53] <ubitux> saste: yes
[22:53] <ubitux> check the 4 patches
[22:53] <ubitux> [PATCH 1/4] lavfi: add frame counter into AVFilterLink and use it in filters.
[22:53] <ubitux> starting here ^
[22:55] <saste> durandal_1707, colorbalance and colormixer are the same thing or I should review both?
[22:55] <ubitux> both are different afaik
[22:58] <durandal_1707> saste: you never used gimp?
[22:58] <saste> durandal_1707, not so often
[22:58] <saste> so what's your answer?
[22:58] <durandal_1707> after ubitux did curves, i got idea, why not add others...
[22:59] <saste> durandal_1707, or we could use libgimp
[22:59] <saste> but wrapping is usually painful (as I'm learning from sox patch)
[22:59] <durandal_1707> we have libmpcodecs
[23:02] <durandal_1707> i just wandted to do sepia, and found that i cant do it with curves, but could with colormixer+colorbalance
[23:43] <cone-986> ffmpeg.git 03Stefano Sabatini 07master:3453b0196fa4: lavfi/split: fix minor documentation issues
[23:43] <cone-986> ffmpeg.git 03Stefano Sabatini 07master:41985cb0ab80: doc/filters: merge asplit and split documentation
[00:00] --- Tue Apr 16 2013