[Ffmpeg-devel-irc] ffmpeg-devel.log.20170827

[burek]

[00:25:22 CEST] <thebombzen> wm4: if I want to use vo_vulkan rn as a test, which development branch should I use (I mean instead of master)
[00:26:51 CEST] <wm4> thebombzen: haasn's repo, vulkan branch
[01:03:02 CEST] <cone-278> ffmpeg 03Martin Vignali 07master:435dd2ee4e08: configure: add avx2 enabled log
[01:57:04 CEST] <graphitemaster> wm4, your sdl example in mpv-examples wrongly assumes fbo 0 is the default framebuffer (this won't work on android for instance where the default fbo is something else entierly)
[01:57:17 CEST] <graphitemaster> you have to actually get the currently bound fbo instead and pass that handle into mpv_opengl_cb_draw
[01:58:14 CEST] <graphitemaster> the iOS example is correct since it gets the framebuffer binding
[03:10:57 CEST] <cone-278> ffmpeg 03James Almer 07master:257f0d09f7b4: avcoec/snowenc: silence some deprecation warnings
[03:38:56 CEST] <iive> graphitemaster: you need to run `perf` as root
[03:39:10 CEST] <iive> and `perf top` is what you might want to try first.
[03:40:03 CEST] <graphitemaster> iive, I did
[03:45:06 CEST] <iive> as kernel options, I think you need CONFIG_PROFILING and OPROFILE
[03:45:54 CEST] <iive> is config_audio about SElinux?
[03:46:04 CEST] <iive> config_audit
[03:46:55 CEST] <iive> gtg, bbl
[06:29:09 CEST] <hanna> graphitemaster: glslang also doesn't install itself properly and doesn't come with a pkgconfig file, at least not here - but that might be a packaging problem (it's not available in the official repos, apparently not for most other major distros as well - so I installed a third party package)
[08:54:19 CEST] <cone-973> ffmpeg 03Paul B Mahol 07master:99b6e68441ce: avfilter/af_amix: do not request samples if inlink reached EOF
[15:55:34 CEST] <BtbN> I somehow doubt that cmd length issue
[15:55:39 CEST] <BtbN> that would have blown up way earlier
[16:34:43 CEST] <rcombs> >PATCH v15 >still has a format-string vuln
[16:35:00 CEST] <JEEB> did anyone bring it up? :D
[16:35:03 CEST] <rcombs> I did, just now
[16:35:05 CEST] <JEEB> ah
[16:35:08 CEST] <JEEB> cool
[16:35:24 CEST] <rcombs> I've responded to this guy's DASH patches so many times pointing out these things
[16:35:34 CEST] <JEEB> \o/
[16:35:36 CEST] <rcombs> and every time he comes back with another one that has a slightly different format-string vuln
[16:35:44 CEST] <rcombs> I don't understand how this happens
[16:35:55 CEST] <JEEB> lol
[16:37:52 CEST] <rcombs> what part of "don't pass file-derived data to snprintf()" doesn't he understand
[16:37:59 CEST] <rcombs> is it the language barrier
[16:38:20 CEST] <JEEB> possibly
[16:38:59 CEST] <rcombs> but yeah unfamiliarity with that very basic principle makes me inclined to recommend multiple passes over this with a fine-toothed comb before it lands
[16:39:15 CEST] <rcombs> (I've looked over it a few times and found some things, but I'd appreciate additional sets of eyes)
[16:40:27 CEST] <JEEB> I'll try to take a look at it some time soon, although I've tried to keep away from the XML side of DASH which is what that mostly touches :D
[16:40:51 CEST] <rcombs> he's also switched from using av_asprintf() to snprintf()+av_malloc()+snprintf() now
[16:41:01 CEST] <rcombs> which is weird, because that's literally what av_asprintf() is
[16:41:12 CEST] <JEEB> yea...
[16:48:26 CEST] <ubitux> av_asprintf is not in libav
[16:49:03 CEST] <ubitux> that might be related
[16:49:09 CEST] <JEEB> I don't think that patch was posted on libav?
[16:50:09 CEST] <JEEB> yea, don't see it on libav-devel
[16:50:30 CEST] <ubitux> dunno, i added it in 2011 in ffmpeg
[17:21:58 CEST] <cone-809> ffmpeg 03Paul B Mahol 07master:2ce43274e392: avfilter/vf_zoompan: switch to activate
[17:21:58 CEST] <cone-809> ffmpeg 03Paul B Mahol 07master:bf39f7eadc68: avfilter/vf_zoompan: parse zoom,x and y expression during initialization
[17:32:27 CEST] <ubitux> v2 fixed: [...] "use API from snprintf to av_asprintf"
[17:32:40 CEST] <ubitux> he probably rolled back because he has troubles with git
[17:33:10 CEST] <ubitux> or maybe that's simply an old patch
[17:36:07 CEST] <jamrial> ubitux: btw, got the major bump working, so we can either apply it at any point after 3.4 is released (michael and marton balint wanted that release before the bump), or once we resume with the merges
[17:43:27 CEST] <ubitux> i won't work on the merge soon
[17:44:45 CEST] <jamrial> alright. i'll send the patchset this week then
[17:49:42 CEST] <jamrial> you got no news from the dashenc guy either?
[17:58:12 CEST] <j-b> BBB: pong
[18:10:57 CEST] <BBB> j-b: nevermind, already figured things out on #videolan
[18:12:03 CEST] <cone-809> ffmpeg 03Marton Balint 07master:76a8b5e7adbb: avdevice/decklink_dec: fix signed and unsigned comparison warning
[18:12:05 CEST] <cone-809> ffmpeg 03pkviet 07master:84ee6512ed70: avdevice/decklink_enc: enable 16 output channel
[18:12:05 CEST] <cone-809> ffmpeg 03Maksym Veremeyenko 07master:2634927fe30e: lavd: implement NewTek NDI input/output device support
[18:30:13 CEST] <durandal_1707> why is there no native decoder for speex codec?
[18:31:50 CEST] <jamrial> same reason there's none for celt i guess, no real interest/use
[18:35:14 CEST] <RiCON> the celt one could be harvested from opus, probably
[19:29:47 CEST] <atomnuker> nah, incompatible
[19:37:00 CEST] <cone-809> ffmpeg 03Michael Niedermayer 07master:7ec414892ddc: avformat/hls: Fix DoS due to infinite loop
[19:37:01 CEST] <cone-809> ffmpeg 03Yi and  *®() 07master:7f9ec5593e04: avformat/asfdec: Fix DoS due to lack of eof check
[19:37:02 CEST] <cone-809> ffmpeg 03Yi and  *®() 07master:7e80b63ecd25: avformat/cinedec: Fix DoS due to lack of eof check
[19:37:03 CEST] <cone-809> ffmpeg 03Yi and  *®() 07master:124eb202e706: avformat/rmdec: Fix DoS due to lack of eof check
[19:37:04 CEST] <cone-809> ffmpeg 03Yi and  *®() 07master:96f24d1bee7f: avformat/rl2: Fix DoS due to lack of eof check
[19:37:05 CEST] <cone-809> ffmpeg 03Michael Niedermayer 07master:4f05e2e2dc1a: avformat/mvdec: Fix DoS due to lack of eof check
[19:40:49 CEST] <kierank> oh lord
[19:40:52 CEST] <kierank> that patchset
[19:43:18 CEST] <jamrial> the author name and email is wtf
[19:44:21 CEST] <jamrial> michaelni: should the error in those be AVERROR_EOF?
[19:44:46 CEST] <jamrial> shouldn't
[20:01:22 CEST] <michaelni> jamrial, some of the patches have 2 authors, which is hard to write cleanly in git
[20:02:49 CEST] <michaelni> about the error codes, a file truncated in the middle of the header is invalid and it is EOF. I can change it t EOF and post a patchset if that is preferred
[20:03:32 CEST] <jamrial> ah. if it's in the middle of the header then no, it's fine as is
[20:04:27 CEST] <jamrial> and IMO, it would have been better to choose one name/email for the author field, then mention the other in the commit message
[20:29:35 CEST] <michaelni> durandal_1707, 2ce43274e39295e3965c51dcfaf802628a5929f9 causes Assertion !(filter->filter->flags & (1 << 16) && filter->filter->activate) failed at libavfilter/avfilter.c:1472
[20:30:13 CEST] <michaelni> ./ffmpeg -f lavfi -i testsrc -vf zoompan -vframes 5  -y a.avi
[20:31:08 CEST] <durandal_1707> michaelni: just remove flag from zoompan for now
[20:53:00 CEST] <cone-809> ffmpeg 03Michael Niedermayer 07master:eefb68c9c335: avcodec/sbrdsp_fixed: Fix undefined overflows in autocorrelate()
[20:53:01 CEST] <cone-809> ffmpeg 03Michael Niedermayer 07master:0181b202cc42: avcodec/aacpsdsp_template: Fix undefined integer overflow in ps_add_squares_c()
[20:53:02 CEST] <cone-809> ffmpeg 03Michael Niedermayer 07master:aa26258faa97: avfilter/vf_zoompan: remove AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC
[21:09:39 CEST] <cone-809> ffmpeg 03Timo Rothenpieler 07master:ef0c6d9b01de: libavutil/opencl: fix potential null dereference
[00:00:00 CEST] --- Mon Aug 28 2017