[Ffmpeg-devel-irc] ffmpeg-devel.log.20170604

burek burek021 at gmail.com
Mon Jun 5 03:05:04 EEST 2017


[00:01:38 CEST] <BtbN> Can someone revert an ban this? That's spam.
[00:24:12 CEST] <cone-367> ffmpeg 03Michael Niedermayer 07master:361e0310d95b: avcodec/mlpdec: Check quant_step_size against huff_lsbs
[00:24:13 CEST] <cone-367> ffmpeg 03Michael Niedermayer 07master:9221445fa001: avcodec/tiff: Use av_fast_padded_malloc() in tiff_unpack_fax()
[00:33:49 CEST] <wm4> michaelni: you ignored my review comments
[00:35:23 CEST] <michaelni> wm4, what comment ? what commit/patch do you mean ?
[00:37:32 CEST] <wm4> the log filename one
[00:39:52 CEST] <michaelni> you said "Mixed opinion about logging that seems dumb, but at least an API user
[00:39:53 CEST] <michaelni> can prevent it." and "But please, don't clutter the code with even more image2 exceptions and
[00:39:53 CEST] <michaelni> special handling." i didnt add any more special cases than what was already i t he patch and mixed oppinion sounded to me that you dont objeject to te patch
[00:40:00 CEST] <michaelni> did i misunderstand you ?
[00:41:34 CEST] <wm4> that was a request to remove those exceptions
[00:41:58 CEST] <wm4> every time I try to debug the garbage in libavformat/utils.c
[00:42:05 CEST] <wm4> you drown in hundreds of such special cases
[00:42:17 CEST] <wm4> which make developing this a pain
[00:42:22 CEST] <wm4> we don't need more of it, rather less
[00:42:32 CEST] <wm4> but I'm sure you don't understand this
[05:40:01 CEST] <kevmark> Trying to build a fate test for scale2ref. Since it has two outputs should I be using overlay (or perhaps v/hstack) to combine the two together so it can be framemd5'd?
[05:41:26 CEST] <kevmark> It doesn't appear there are any explicit tests for the split filter so I haven't found any examples of testing filters with multiple outputs
[05:44:58 CEST] <kevmark> Or I suppose I could send the input that remains unchanged to nullsink because there's no point (I suppose) in testing something that the filter doesn't change
[06:36:41 CEST] <philipl> BtbN: perhaps unsurprisingly, the 1030 doesn't have any encode capability - only decode.
[11:09:46 CEST] <BtbN> philipl, given that my old gt630 had full encode caps, it's a bit surprising and sad
[13:44:05 CEST] <Compn> maybe the trick is
[13:45:40 CEST] <Compn> that we convince the distros, especially the older slower 10-year long term ones, to accept static binaries for projects that require the latest and greatest
[13:46:40 CEST] <Compn> for example, web browsers, multimedia and whatever other projects that have to have the latest versions
[13:47:33 CEST] <Compn> because we cant convince users of these old OS to upgrade, that would be a foul
[13:47:46 CEST] <Compn> but we can convince the distros to stop shipping 2 year old versions.
[13:55:15 CEST] <DHE> as a user of said 10 year old distro (well, 7) can confirm binary executables and source code both have compatibility issues
[13:55:47 CEST] <Compn> even static binaries ?
[13:56:36 CEST] <Compn> also, then i'd suggest going further into a distro VM for updated programs
[13:56:52 CEST] <Compn> official distro updated vm, specifically for updated projects
[13:56:56 CEST] Action: Compn will not rest.
[14:04:23 CEST] <cone-027> ffmpeg 03Michael Niedermayer 07master:98256595fae1: avcodec/tiff: Clear deinvert_buf_size on deallocation
[14:04:23 CEST] <cone-027> ffmpeg 03Michael Niedermayer 07master:136ce8baa4fc: avcodec/ac3dec_fixed: Fix runtime error: left shift of 419 by 23 places cannot be represented in type 'int'
[14:04:23 CEST] <cone-027> ffmpeg 03Michael Niedermayer 07master:faa5a2181df5: avcodec/pafvideo: Check packet size and frame code before ff_reget_buffer()
[14:09:43 CEST] <DHE> Compn: static binaries are fine. but glibc symbols and autoconf versions usually ruin my day if simple dependencies don't do it
[14:19:44 CEST] <Compn> i'm glad it works then, now to convince distroooooooo
[15:09:29 CEST] <cone-027> ffmpeg 03Marton Balint 07master:47c699f7be16: avformat/utils: return impaired streams in av_find_best_stream if only those exist
[15:09:30 CEST] <cone-027> ffmpeg 03Marton Balint 07master:880504814a84: avformat/utils: change bitrate to int64_t in av_find_best_stream
[16:00:45 CEST] <Compn> https://github.com/leandromoreira/digital_video_introduction
[16:03:36 CEST] <Compn> michaelni : they use ffmpeg motion vectors to teach people ^^
[16:04:42 CEST] <Compn> BBB : didnt you make an app to do video analyzing? wonder if these people could use it as well ?
[16:04:52 CEST] <Compn> educational purposes
[16:13:06 CEST] <bencoh> looks nice :)
[16:29:09 CEST] <DHE> <Compn> i'm glad it works then, now to convince distroooooooo  # there's limits to static libraries though. for example I'm running folding at home. dynamic linking is mandatory because the GPU driver and version is unknown until runtime
[16:36:28 CEST] <Compn> sure
[16:38:45 CEST] <cone-027> ffmpeg 03Paul B Mahol 07master:fab1863917b8: avfilter/af_surround: add support for some upmixing of 3.0, 2.1 and 5.1 channel layout
[16:53:27 CEST] <cone-027> ffmpeg 03James Almer 07master:3d4026325381: avformat/aacdec: add a custom read_packet function
[17:07:01 CEST] <durandal_1707> atomnuker: what happened to your audio denoising filter?
[17:19:12 CEST] <atomnuker> a dog ate my code
[17:19:53 CEST] <atomnuker> yesterday I realized I had a use for it so I've started to write it now
[17:49:31 CEST] <BBB> Compn: I did, yes - but it already exists opensource and web-based for av1 so no need to use mine if its educational only
[17:49:59 CEST] <BBB> Compn: and I did read that guide, its quite cool although later on when it talkes about b/p prediction etc. it gets sort of simplistic
[17:52:26 CEST] <cone-027> ffmpeg 03Michael Niedermayer 07master:eb5049227033: avcodec/dxv: Check remaining bytes in dxv_decompress_raw()
[17:52:27 CEST] <cone-027> ffmpeg 03Michael Niedermayer 07master:29808fff339d: avcodec/hevc_ps: Fix runtime error: index 32 out of bounds for type 'uint8_t [32]'
[17:52:28 CEST] <cone-027> ffmpeg 03Michael Niedermayer 07master:e2bbb95d5821: avcodec/wavpack: Fix runtime error: signed integer overflow: 2081021665 - -130689706 cannot be represented in type 'int'
[18:44:31 CEST] <durandal_1707> michaelni: how are integer overflows issues important at a:l?
[18:46:13 CEST] <michaelni> (signed) integer overflow is not allowed in C
[19:02:46 CEST] <rcombs> "not allowed" == "undefined behavior"
[19:02:56 CEST] <rcombs> if it was just "implementation-defined" then that'd be fine
[19:03:07 CEST] <rcombs> but it's actually UB, which is potentially a mess
[19:03:51 CEST] <rcombs> I've seen some fun cases where people assume signed overflow will behave in C as it does on the underlying hardware, and do an `if (<result of math> < 0)` check
[19:04:03 CEST] <rcombs> and then the compiler optimizes out the check, because it can never be true unless UB has happened
[19:22:36 CEST] <DHE> gcc -fsanitize=thread reports that sws_getContext is not thread safe because you can have a race involving multiple threads invoking ff_sws_rgb2rgb_init()...
[19:27:23 CEST] <DHE> I suspect a false positive but still..
[19:45:30 CEST] <atomnuker> I'm not tripping and there is a vts.profile-vc2-low-delay.drc in fate_samples/dirac, right?
[21:09:43 CEST] <jamrial> rcombs: can you look at the audiotoolboxdec patchset?
[21:10:25 CEST] <jamrial> first and second are important to fix potential memleaks (would also be nice if you can confirm they exist and are fixed by the patches)
[22:10:31 CEST] <atomnuker> michaelni: could you upload this sample to the fate samples repo under dirac? https://pars.ee/temp/vts.profile-vc2-low-delay.drc
[22:53:46 CEST] <cone-243> ffmpeg 03Paul B Mahol 07master:67162554d458: avfilter/af_afftfilt: fix memory leaks
[22:59:52 CEST] <michaelni> atomnuker, done
[23:01:54 CEST] <kierank> J_Darnley: ping
[23:37:27 CEST] <atomnuker> michaelni: thanks
[23:37:47 CEST] <atomnuker> if you had time could you check to see if the patch I sent on the ML to add a test for it is okay
[23:42:14 CEST] <cone-243> ffmpeg 03Michael Niedermayer 07master:6019d721d4c1: avutil/softfloat: Fix sign error in and improve documentation of av_int2sf()
[23:42:15 CEST] <cone-243> ffmpeg 03Michael Niedermayer 07master:b315a3cf42a1: avcodec/sbrdsp_fixed: Fix assertion failure in sbr_sum_square_c()
[23:42:16 CEST] <cone-243> ffmpeg 03Michael Niedermayer 07master:46b865ea9f86: avcodec/qdrw: Fix null pointer dereference
[00:00:00 CEST] --- Mon Jun  5 2017


More information about the Ffmpeg-devel-irc mailing list