[Ffmpeg-devel-irc] ffmpeg-devel.log.20171015

[burek]

[00:13:44 CEST] <cone-802> ffmpeg 03Michael Niedermayer 07master:9c85329cd02e: avcodec/pafvideo: Check for bitstream end in decode_0()
[00:13:45 CEST] <cone-802> ffmpeg 03Michael Niedermayer 07master:393d6fc73956: avcodec/snowdec: Check mv_scale
[00:13:46 CEST] <cone-802> ffmpeg 03Michael Niedermayer 07master:cd2f69cdd63d: avcodec/dvbsubdec: Factor a few expressions out of compute_default_clut()
[00:13:47 CEST] <cone-802> ffmpeg 03Michael Niedermayer 07master:963247b5f36a: avcodec/dvbsubdec: Split best score computation out of loop in compute_default_clut()
[02:02:08 CEST] <cone-802> ffmpeg 03Ivan Kalvachev 07release/3.4:a11a18b284af: Fix visual glitch with XvMC, caused by wrong idct permutation.
[02:02:09 CEST] <cone-802> ffmpeg 03Sasi Inguva 07release/3.4:8500de89ea91: ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.
[02:02:10 CEST] <cone-802> ffmpeg 03Michael Niedermayer 07release/3.4:35e36046f1a3: avcodec/pafvideo: Check for bitstream end in decode_0()
[02:02:11 CEST] <cone-802> ffmpeg 03Michael Niedermayer 07release/3.4:46abeb1c3223: avcodec/snowdec: Check mv_scale
[02:37:53 CEST] <cone-802> ffmpeg 03James Almer 07master:065581007274: configure: add pkg-config checks for libcdio/cdparanoia
[02:59:48 CEST] <cone-802> ffmpeg 03Michael Niedermayer 07release/3.4:03351cce8843: Update versions for 3.4 release
[14:08:39 CEST] <cone-633> ffmpeg 03Mark Thompson 07release/3.4:01e291a59245: hwcontext_vaapi: Remove use of vaExportSurfaceHandle()
[14:37:30 CEST] <ubitux> ~g 
[14:37:32 CEST] <ubitux> oups
[19:30:35 CEST] <cone-276> ffmpeg 03James Almer 07n3.4:HEAD: configure: add pkg-config checks for libcdio/cdparanoia
[21:41:08 CEST] <Zeranoe> Any chance this can get merged? https://ffmpeg.org/pipermail/ffmpeg-devel/2017-October/217977.html
[21:47:10 CEST] <Snaggle> What is the benefit of use_pkg_config over require_pkg_config or vice versa? Is there a preferred one for finding external libraries?
[21:48:51 CEST] <BtbN> Doesn't require just die if it doesn't find its stuff?
[21:49:17 CEST] <BtbN> just look at the functions if you want to know the difference
[21:59:14 CEST] <nevcairiel> require should usually be preferred if there is always a pc file
[21:59:20 CEST] <nevcairiel> use is only for special circumstances
[22:00:11 CEST] <BtbN> like if there could be multiple ones and you try them one after the other
[22:34:49 CEST] <jamrial> i could use a review for the configure patchset i sent (not numbered, but it's three patches in one thread)
[22:36:07 CEST] <BtbN> I'm also running in a linker error on Gentoo. But it's quite a configure invocation
[22:36:31 CEST] <BtbN> Also, configure is _really_ slow there
[22:36:46 CEST] <BtbN> With all those options gentoo puts there, it thinks about them for a good few minutes
[22:42:51 CEST] <jamrial> most external library check problems will be gone with that patchset, since it adds lm and pthreads to global extralibs
[22:46:14 CEST] <BtbN> You mean https://patchwork.ffmpeg.org/patch/5561/ https://patchwork.ffmpeg.org/patch/5562/ https://patchwork.ffmpeg.org/patch/5563/ ?
[22:48:35 CEST] <BtbN> Just noticed that gentoo patches ffmpeg to build ffmpeg.c into libffmpeg.so oO
[22:48:50 CEST] <BtbN> https://github.com/gentoo/gentoo/blob/master/media-video/ffmpeg/files/chromium.patch
[22:50:10 CEST] <BtbN> hm, it's not ffmpeg.c, but all the libs linked together?
[22:54:25 CEST] <BtbN> jamrial, even with your 3 patches applies, I still get libavutil/libavutil.so: undefined reference to dlopen/dlclose/dlsym
[22:54:34 CEST] <BtbN> So something is missing $ldl
[22:55:32 CEST] <BtbN> It happens during make of tools/ffescape
[22:56:25 CEST] <BtbN> The configure line is quite something though: https://bpaste.net/show/66193e054923
[22:57:03 CEST] <jamrial> cuda, omx, nvenc, avysynth, decklink, frei0r and ladspa are listed as needing libdl
[22:57:40 CEST] <BtbN> none of those are enabled in that build
[22:58:40 CEST] <BtbN> ./libavutil/hwcontext_cuda.o it the culprit
[22:59:39 CEST] <jamrial> cuda_deps_any="libdl LoadLibrary"
[22:59:49 CEST] <jamrial> but it seems it's not being added to libavutil
[23:00:18 CEST] <BtbN> Is the hwcontext_cuda stuff missing a dep on cuda?
[23:00:41 CEST] <BtbN> Can you even define deps for stuff in libavutil?
[23:01:34 CEST] <jamrial> i think i found what's missing
[23:19:40 CEST] <jamrial> BtbN: try https://pastebin.com/HXn1NeMN
[23:21:22 CEST] <BtbN> what does suggest even mean in the context of configure?
[23:24:09 CEST] <BtbN> The patch doesn't apply for me
[23:24:12 CEST] <jamrial> it adds the listed module's extralibs to the target module's extralibs if the former is enabled, or if it can be enabled in the process
[23:24:48 CEST] <jamrial> pull new commits? it should apply with git head
[23:24:53 CEST] <BtbN> I'm applying it to master after the 3 patches from the ml
[23:25:17 CEST] <jamrial> ah, yeah, it clashes with those
[23:25:17 CEST] <jamrial> one sec
[23:26:35 CEST] <jamrial> BtbN: https://pastebin.com/sHMeiBar
[23:27:17 CEST] <BtbN> that applies, lets see how the build goes
[23:28:34 CEST] <jamrial> that configure line is full of pointless stuff, btw
[23:28:57 CEST] <jamrial> lots of --disable-something for things that are disabled by default
[23:29:05 CEST] <nevcairiel> looks like autogenerated shit from gentoo or something
[23:29:18 CEST] <nevcairiel> their cpu flag handling for ffmpeg is dumb as fuck
[23:29:29 CEST] <jamrial> yeah, it disables simd from four different arches, lol
[23:29:32 CEST] <nevcairiel> just let ffmpeg handle it, we have runtime detection
[23:30:01 CEST] <BtbN> There's a useflag for that
[23:30:07 CEST] <BtbN> which should be enabled by default, but isn't
[23:31:06 CEST] <thebombzen> --enable-runtime-cpudetect yea
[23:31:26 CEST] <nevcairiel> that flag also doesnt do shit
[23:31:34 CEST] <BtbN> Well, in ffmpeg that clearly is the default
[23:31:35 CEST] <nevcairiel> you cant disable that
[23:31:50 CEST] <thebombzen> then why does the option exist? shouldn't it just be removed?
[23:32:10 CEST] <BtbN> Maybe just removing it would make the gentoo maintainer re-think
[23:32:17 CEST] <BtbN> He only reacts when the build is broken
[23:32:31 CEST] <BtbN> doesn't even care about the "sdl is unknown" warnings it spews
[23:32:36 CEST] <BtbN> Because it was never updated to sdl2
[23:33:03 CEST] <nevcairiel> git ebuilds are often quite a mess
[23:33:30 CEST] <BtbN> Well, in theory you continously maintain a git ebuild. And when a release comes you copy it at that time, and have your release ebuild.
[23:33:53 CEST] <BtbN> But the ffmpeg maintainer in gentoo is kind of not overly interested in doing work
[23:38:55 CEST] <BtbN> jamrial, no that doesn't make libavutil link against libdl
[23:39:23 CEST] <jamrial> BtbN: it should
[23:39:32 CEST] <jamrial> maybe it's what nevcairiel found about flatten_libs() again
[23:39:49 CEST] <jamrial> too many layers of deps
[23:40:52 CEST] <nevcairiel> probably the same issue
[23:41:06 CEST] <nevcairiel> I should remember to ping diego about that tomorrow
[23:41:28 CEST] <nevcairiel> they actually have cuda, so maybe i can make an actual example
[23:41:47 CEST] <BtbN> it's only the cuda stuff in avutil
[23:42:07 CEST] <BtbN> cuvid in avcodec probably has the same issue though. But the deps work there I guess?
[23:42:48 CEST] Action: ubitux remembers android linker being annoying when not specifying -l* in the "correct" order and wonder if the commit will affect that
[23:43:00 CEST] <nevcairiel> the issue only manifests itself if one component is used by two libraries, and that component has nested deps
[23:43:24 CEST] <BtbN> so as a workaround, just adding libdl there directly should work for now?
[23:44:32 CEST] <jamrial> BtbN: https://pastebin.com/iCfqyjLi
[23:44:37 CEST] <jamrial> yeah, that one should work
[23:44:49 CEST] <jamrial> but it's Not Ideal(tm)
[23:45:53 CEST] <BtbN> Wasn't there a major bump planned soon?
[23:46:23 CEST] <BtbN> (unrelated)
[23:47:40 CEST] <jamrial> yeah
[23:48:55 CEST] <jamrial> we're close to it in the merge queue, so i'll probably apply it as i merge it
[23:49:03 CEST] <jamrial> but if merges take too long though, i'll apply it on its own since i want enough time before 4.0 is tagged to do the usual post bump cleaning
[23:53:26 CEST] <BtbN> Time to merge all the libraries. Should make dependencies way easier!
[23:53:55 CEST] <jamrial> if there's a time to troll in that regard, this is it :p
[23:55:59 CEST] <BtbN> I don't know, why not? It would make a lot of things easier.
[23:56:27 CEST] <BtbN> People who need absolutely minimal builds build them themselves anyway, and they can just disable all the components that are in other libraries now.
[00:00:00 CEST] --- Mon Oct 16 2017