[Ffmpeg-devel-irc] ffmpeg-devel.log.20180718

[burek]

[01:39:38 CEST] <jdarnley> > Ticket #7318 (Freezing glitch)
[01:39:53 CEST] <jdarnley> All programs in windows cmd do that.
[01:40:33 CEST] <jdarnley> I would guess that writes to the terminal block when you're using it.
[01:40:47 CEST] <jdarnley> well, "terminal"
[01:42:41 CEST] <kierank> linux does that as well I think
[11:56:50 CEST] <cone-193> ffmpeg 03James Darnley 07master:088b07427dfe: fate: add more vc2 encoder tests
[13:28:10 CEST] <atomnuker> jdarnley: wtf
[13:28:15 CEST] <atomnuker> I didn't ack the commit
[13:29:26 CEST] <jdarnley> I was unaware that you had to.
[13:29:52 CEST] <atomnuker> I'm still the maintainer, so I _have_ to
[13:30:14 CEST] <durandal_1707> !drama time!
[13:31:46 CEST] <nevcairiel> he didnt even touch your precious encoder =p
[13:32:22 CEST] <jdarnley> Feel free to ask anything you want here or on the list.
[13:33:43 CEST] <atomnuker> in any caase its fine
[13:38:30 CEST] <jdarnley> durandal_1707: sorry, no drama this time
[13:47:24 CEST] <gagandeep> guys, ff_thread_get_buffer allocates buffer for all the planes required by just calling it once or just one plane
[13:48:40 CEST] <durandal_1707> jdarnley: revert! revert!
[14:01:42 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07master:706c9beaead7: avcodec/lagarith: Remove redundant varianble init
[14:01:43 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07master:91578f5798d3: avcodec/tscc: Move reget buffer to after decoding
[14:01:44 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07master:4a657acaefd5: avcodec/cfhd: Use bytestream2 for peaks
[14:01:45 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07master:1809f1cda956: avcodec/dvbsub_parser: Do not discard data
[14:05:20 CEST] <gagandeep> nevermind, finally found the default function used for this
[15:05:37 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07release/4.0:0a155c57bd8e: Update for 4.0.2
[15:29:50 CEST] <cone-193> ffmpeg 03Rahul Chaudhry 07release/3.4:a8c5c71a0489: swresample/arm: rename labels to fix xcode build error
[15:29:51 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07release/3.4:2b8d4f6f0186: avformat/movenc: Write version 2 of audio atom if channels is not known
[15:29:52 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07release/3.4:15990a43b023: avcodec/dirac_dwt_template: Fix signedness regression in interleave()
[15:29:53 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07release/3.4:6ea8b39c9057: avcodec/dvdsub_parser: Init output buf/size
[15:29:54 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07release/3.4:6f354ca5fd5e: avcodec/dvdsub_parser: Allocate input padding
[15:29:55 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07release/3.4:8df2c7dde6af: Update for 3.4.4
[16:14:28 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07n4.0.2:HEAD: avcodec/dvbsub_parser: Do not discard data
[16:43:18 CEST] <cone-193> ffmpeg 03Michael Niedermayer 07n3.4.4:HEAD: avcodec/dvbsub_parser: Do not discard data
[16:46:36 CEST] <durandal_1707> atomnuker: many of my projects depends on your work!
[17:10:18 CEST] <atomnuker> sorry if I get hit by a truck
[17:10:53 CEST] <kierank> durandal_1707: don't you know main reason for maintainer is to block other people changes and to force in crap code
[17:29:55 CEST] <durandal_1707> kierank: looks like you gonna do full conversion to Nicolas mode?
[17:30:19 CEST] <kierank> durandal_1707: why
[17:30:29 CEST] <kierank> durandal_1707: you should come to no time to wait
[17:31:12 CEST] <durandal_1707> too far away
[17:32:07 CEST] <atomnuker> if you want to know how too far away is you should try a 12 hour flight to San Francisco
[17:34:58 CEST] <kierank> durandal_1707: 2hr by plane
[20:07:13 CEST] <tmm1> looks like AVCodec.bsfs doesn't work with multiple comma separated filters
[20:08:44 CEST] <jamrial> tmm1: odd, it should
[20:08:52 CEST] <jamrial> bsfs_init() in decode.c has code to handle that
[20:09:35 CEST] <tmm1> yea i think it has some sort of bug.. it says non-existing bitstream filter ''
[20:09:39 CEST] <jamrial> no decoder currently uses more than one, though
[20:10:28 CEST] <jamrial> post your code?
[20:16:46 CEST] <tmm1> i set bsfs = "h264_mp4toannexb,h264_metadata"
[20:16:52 CEST] <tmm1> it looks like the tokenzier isn't working correctly
[20:17:18 CEST] <tmm1> first iteration is "h264_mp4toannexb", second iteration is ""
[20:18:38 CEST] <tmm1> off by one i think
[20:18:59 CEST] <tmm1> bsfs_str = ",h264_metadata" on second iteration, so the parser returns "" before the comma
[20:22:10 CEST] <jamrial> tmm1: does https://pastebin.com/D1XT2pRS fix it?
[20:23:58 CEST] <tmm1> i did https://pastebin.com/t4RzsyVT
[20:25:09 CEST] <jamrial> my patch copies the behavior of the similar loop in ffmpeg_opt.c
[20:25:59 CEST] <tmm1> ok let me verify it works
[20:26:34 CEST] <tmm1> jamrial: yep that works
[20:26:38 CEST] <tmm1> do you want to email/commit it?
[20:26:55 CEST] <jamrial> also, what decoder would use h264_metadata? you can't even pass option arguments for it to do anything but packet passthrough
[20:27:05 CEST] <jamrial> i'll send the patch to the ml, yeah
[20:30:43 CEST] <tmm1> yea that's next on my list, figure out how to pass options to it =)
[20:31:19 CEST] <tmm1> i'm trying to use it from h264_mediacodec to extract a53 data
[20:32:33 CEST] <jamrial> you'd have to add an extra av_get_token() call looking for "=" after the comma, then use av_dict_parse_string() or such to parse the options part of the string
[20:33:46 CEST] <tmm1> that doesn't seem to bad
[20:33:51 CEST] <tmm1> how would you pass the options into the bsf itself?
[20:34:41 CEST] <jamrial> as part of the avcodec.bsfs string. so instead of "h264_mp4toannexb,h264_metdata" it would be "h264_mp4toannexb,h264_metdata=opt=value:opt2=value2" and similar
[20:35:31 CEST] <tmm1> right i get that part, but once parsed into a dict how do i use it with av_bsf_init()
[20:36:37 CEST] <tmm1> i guess just set the options onto the AVBSFContext*
[20:37:04 CEST] <jamrial> yes, in AVBSFContext->priv_data
[20:37:35 CEST] <jamrial> with av_opt_set_dict()
[20:38:15 CEST] <tmm1> thanks, i'll try it out
[20:38:16 CEST] <jamrial> alternatively, do what ffmpeg_opt.c does in new_output_stream()
[20:38:23 CEST] <jamrial> using av_opt_set_from_string() to do both at the same time
[20:38:39 CEST] <tmm1> oh cool
[20:43:56 CEST] <jamrial> it also lets you omit the option name in the string if it's the first one and if you set a shorthand, so you could do "h264_metadata=value:opt2=value"
[20:49:11 CEST] <tmm1> cool it works
[20:49:17 CEST] <tmm1> https://paste.ubuntu.com/p/2r5rJDNHbP/
[20:52:57 CEST] <jamrial> i'd set the error to AVERROR_BUG and change the printed message accordingly, since much like the one about the missing filter, wrong options in the string should not happen
[20:53:30 CEST] <tmm1> right ok
[20:54:34 CEST] <jamrial> it'd be a developer error, not a user error or something unexpected like oom
[20:55:52 CEST] <tmm1> makes sense
[20:56:07 CEST] <tmm1> i'm just going to combine the other parsing fix into this patch and send it to the list
[20:56:15 CEST] <jamrial> alright
[20:57:41 CEST] <jamrial> although av_opt_set_from_string() can return ENOMEM, which should be returned as is
[20:58:46 CEST] <tmm1> if (ret != AVERROR(ENOMEM)) ret = AVERROR_BUG; ?
[21:03:35 CEST] <jamrial> if (ret < 0) { if (ret == enomem) { av_log("no memory"); } else { av_log("bug"); ret = bug; } goto fail; }
[21:03:40 CEST] <jamrial> or such is probably better
[21:06:04 CEST] <jamrial> the "Error parsing options for bitstream filter %s\n" message in your patch for the enomem case should be fine
[21:06:08 CEST] <jamrial> the actual "no memory" error will be printed later based on the return value
[21:09:48 CEST] <tmm1> ok
[21:13:33 CEST] <tmm1> thanks for the help
[21:25:09 CEST] <jamrial> no prob
[22:16:37 CEST] <durandal_1707> d9 is down! no more AS and VS
[22:45:00 CEST] <DHE> still?
[22:45:23 CEST] <JEEB> most likely: swede's on holidays and the box in his basement went down
[22:45:34 CEST] <JEEB> nordics in general is far away from home these months
[22:46:36 CEST] <DHE> months?!
[22:46:39 CEST] <nevcairiel> yeah crazy nordics and their long summer vacation, all at the same time
[22:58:26 CEST] <JEEB> that's why the Finnish railroad company can just start breaking people's routes during July
[22:58:35 CEST] <JEEB> because most people are Somewhere Esle
[22:58:37 CEST] <JEEB> *Else
[23:03:22 CEST] <jdarnley> Sounds similar to the Dutch Belgians and some Germans.
[23:03:32 CEST] <jdarnley> Well, not the railroad part.
[23:03:44 CEST] <jdarnley> They clog up roads through France on a few weekends over the summer.
[23:04:37 CEST] <jdarnley> "School's out, kids.  We're migrating south."
[23:28:20 CEST] <cone-519> ffmpeg 03James Almer 07release/3.2:e870255e4e3d: avformat/utils: fix mixed declarations and code
[23:28:20 CEST] <cone-519> ffmpeg 03Rahul Chaudhry 07release/3.2:a1d4de0559cc: swresample/arm: rename labels to fix xcode build error
[23:28:20 CEST] <cone-519> ffmpeg 03Michael Niedermayer 07release/3.2:2c0e98a0b478: avformat/movenc: Write version 2 of audio atom if channels is not known
[23:28:20 CEST] <cone-519> ffmpeg 03Michael Niedermayer 07release/3.2:fe73afd730be: avcodec/dirac_dwt_template: Fix signedness regression in interleave()
[23:28:20 CEST] <cone-519> ffmpeg 03Michael Niedermayer 07release/3.2:ffc9ef8f4c74: avcodec/dvdsub_parser: Init output buf/size
[23:28:21 CEST] <cone-519> ffmpeg 03Michael Niedermayer 07release/3.2:94fda4f9ec95: avcodec/dvdsub_parser: Allocate input padding
[23:28:21 CEST] <cone-519> ffmpeg 03Michael Niedermayer 07release/3.2:a911f234e26e: Update for 3.2.12
[23:44:03 CEST] <cone-519> ffmpeg 03Michael Niedermayer 07n3.2.12:HEAD: avcodec/dvbsub_parser: Do not discard data
[00:00:00 CEST] --- Thu Jul 19 2018