[Ffmpeg-devel-irc] ffmpeg-devel.log.20181101

[burek]

[00:07:04 CET] <atomnuker> BBB: I'm getting a stack smash abort, and I've already wrapped all cdfs in cdf.h using ALIGN(, 16);
[00:07:19 CET] <atomnuker> is there somewhere in the decoder where the CDF isn't taken from that array but is on stack?
[00:12:19 CET] <atomnuker> seems to be msac_decode_bool_adapt()
[00:27:32 CET] <atomnuker> ALIGN doesn't seem to be working as I'd expected, my code only works if I create a temporary cdf and then copy the updated one back
[00:27:54 CET] <atomnuker> otherwise I get a desync
[01:10:16 CET] <BBB> atomnuker: not quite sure, but yes, bool uses one on the stack and probably shouldnt use the update_cdf anyway (it can use an optimized update which is purely boolean)
[01:36:37 CET] <cone-330> ffmpeg 03Philip Langdale 07master:4a976200d785: avcodec/vdpau: Initialise driver version variable explicitly
[01:55:55 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:ea160f02137e: avutil/pixfmt: Document chroma plane size for odd resolutions
[01:55:56 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:31262860ccd3: swresample/swresample: Fix input channel count in resample_first computation
[01:55:57 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:922a29142e77: avcodec/diracdec: Prevent integer overflow in intermediate in global_mv()
[01:55:58 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:d5c48e8536d0: avcodec/dirac_dwt_template: Fix several integer overflows in horizontal_compose_daub97i()
[01:55:59 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:ee5b42ce2f2f: avcodec/diracdec: Change frame_number to 64bit as its a 32bit from the bitstream and we also have a -1 special case
[01:56:00 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:c07d568603d3: avcodec/diracdec: Check slice numbers for overflows in relation to picture dimensions
[01:56:01 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:c1a3212d45a9: avcodec/diracdec: Check bytes count in else branch in decode_lowdelay() too
[01:56:02 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:1e1c02c51b3b: avcodec/qtrle: Check remaining bytestream in qtrle_decode_XYbpp()
[01:56:03 CET] <cone-330> ffmpeg 03Nikolas Bowe 07release/3.3:e2d052d5c832: lavc/svq3: Fix regression decoding some files.
[01:56:04 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:0026d007428a: avformat/flvenc: Check audio packet size
[01:56:05 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:0678985c14dd: avcodec/aacpsdsp_template: Fix integer overflow in ps_stereo_interpolate_c()
[01:56:06 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:0ea1b62b9ac5: avcodec/mpegaudio_parser: Initialize poutbuf*
[01:56:07 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:488c246bf565: avcodec/shorten: Check verbatim length
[01:56:08 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:d16d851238f4: avcodec/shorten: Fix integer overflow in residual/LPC combination
[01:56:09 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:298ca73ab14b: avcodec/shorten: Fix signed 32bit overflow in shift in shorten_decode_frame()
[01:56:10 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:907699d1207f: avcodec/scpr: Check for min > max in decompress_p()
[01:56:11 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:44ebea8657e2: avformat/rmdec: Fix EOF check in the stream loop in ivr_read_header()
[01:56:12 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:24add16a3236: avformat/mlvdec: read_string() received unsigned size, make the argument unsigned
[01:56:13 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:b80d7d4a0920: avformat/nsvdec: Do not parse multiple NSVf
[01:56:14 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:dc8ec1a5bc85: avcodec/snowdec: Fix integer overflow with motion vector residual
[01:56:15 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:347c50b0d4e7: avcodec/vb: Check for end of bytestream before reading blocktype
[01:56:16 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:66331499a7d2: avcodec/hq_hqa: Check remaining input bits in hqa_decode_mb()
[01:56:17 CET] <cone-330> ffmpeg 03Michael Bunk 07release/3.3:7266a6d23c89: examples: Fix use of AV_CODEC_FLAG_GLOBAL_HEADER
[01:56:18 CET] <cone-330> ffmpeg 03Dale Curtis 07release/3.3:1acec9bbf55b: avformat/mov: Error on too large stsd entry counts.
[01:56:19 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:78a1db00c4c4: avcodec/indeo4: Check dimensions in decode_pic_hdr()
[01:56:20 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:5c91bb1881a8: avcodec/ra144: Fix undefined integer overflow in add_wav()
[01:56:21 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:fa5498cb4dae: avcodec/h264_refs: Document last if() in ff_h264_execute_ref_pic_marking()
[01:56:22 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:46875255bc95: avcodec/dvdsubdec: Avoid branch in decode_run_8bit()
[01:56:23 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:3c3b437d7947: avcodec/shorten: Fix bitstream end check in read_header()
[01:56:24 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:bf4026fcbee8: avcodec/zmbv: Update decomp_len in raw frames
[01:56:25 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:7fb45ccf4ef5: avcodec/zmbv: Check that the decompressed data size is correct
[01:56:26 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:43a80efee600: avcodec/mpeg4videodec: Fix undefined shift in get_amv()
[01:56:27 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:6177ed2a9b70: avcodec/dvdsubdec: Sanity check len in decode_rle()
[01:56:28 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:a9ce7cfc5949: avcodec/unary: Improve get_unary() docs
[01:56:29 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:1e59d05e48f9: avformat/utils: Fix integer overflow in discontinuity check
[01:56:30 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:a1f4fe165a40: avformat/utils: Never store negative values in last_IP_duration
[01:56:31 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:caddb7890aa6: avcodec/ra144: Fix integer overflow in add_wav()
[01:56:32 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:65710b7e6c89: avcodec/h264_cavlc: Check mb_skip_run
[01:56:33 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:947f7af04821: avcodec/mpeg4videodec: Fix typo in sprite delta check
[01:56:34 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:98444e0222ed: avcodec/jpeg2000dec: Fix off by 1 error in JPEG2000_PGOD_CPRL handling
[01:56:35 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:2405af5081a9: avcodec/msrle: Check that the input is large enough to contain a end of picture code
[01:56:36 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:72e1c43d6df5: avutil/integer: Fix integer overflow in av_mul_i()
[01:56:37 CET] <cone-330> ffmpeg 03Michael Niedermayer 07release/3.3:6fe9f36dd994: Update for FFmpeg 3.3.9
[02:14:54 CET] <Gramner> fwiw shrx is faster than shifting by cl
[02:16:13 CET] <Gramner> shr r,cl is 2/2 (3 µops), shrx r,r,r is 1/0.5 (1 µop)
[02:17:47 CET] <Gramner> and no, that doesn't make any sense. just intel things.
[02:28:02 CET] <jamrial> worth the extra byte then
[02:41:30 CET] <BBB> hm& bmi2
[02:41:33 CET] <BBB> whats that
[02:41:36 CET] <BBB> do I have that?
[02:41:52 CET] <BBB> Ive always wanted a shift instruction that did not need cl
[02:42:08 CET] <Gramner> bmi2 == avx2 in practice
[02:44:41 CET] <Gramner> as in all cpus with avx2 have bmi2, and all cpus with bmi2 has avx2
[02:48:28 CET] <Gramner> since it uses vex encoding those budget cpus with AVX fused off for marget segmentation reasons also lack bmi
[03:45:45 CET] <nicolas17> when using a big image sequence as input, often I see neither CPU nor I/O are saturated, because ffmpeg reads one file (CPU idle) and then decodes it (I/O idle)
[03:46:16 CET] <nicolas17> if I do "cat *.jpg > /dev/null" in the background, overall performance improves
[03:46:24 CET] <nicolas17> would it make sense to add pre-fetching to ffmpeg itself?
[04:12:47 CET] <nicolas17> https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavformat/img2dec.c "reading blob failed"?
[04:14:40 CET] <nicolas17> https://github.com/FFmpeg/FFmpeg/blob/master/libavformat/img2dec.c#L130 is this doing a binary search?
[04:39:39 CET] <philipl> Because I like to double down on bad life choices, I'm now trying to implement bwdif in cuda. It seems mostly working but I clearly see small artifacts in sample playback that aren't in the CPU version. Can't see any errors in the algorithm at this point.
[04:40:22 CET] <nicolas17> looks like it's not quiiite a binary search but similar idea
[04:40:31 CET] <nicolas17> I'm not sure if it's wise, what if there are gaps in the sequence?
[11:15:05 CET] <durandal_1707> is there tool to display raw bayer pixels, you just specify dimensions and pattern?
[13:52:33 CET] <cone-316> ffmpeg 03Paul B Mahol 07master:d98fb558be9c: doc/filter: add some loop filter trivial examples
[15:56:37 CET] <cone-316> ffmpeg 03Michael Niedermayer 07release/3.4:cb74b3ff27d5: Update for 3.4.5
[18:16:57 CET] <atomnuker> BBB: opened a pr for the wip simd
[18:17:40 CET] <atomnuker> help on why it corrupts other CDFs welcome, not even ALIGN(, 128) helps
[18:27:10 CET] Action: durandal_1707 *cries*
[18:29:10 CET] <atomnuker> is it that cold over there already for electricity bills to do that?
[18:29:33 CET] <durandal_1707> how did you guess?
[18:34:09 CET] <atomnuker> s-same -_-
[18:45:07 CET] <kurosu_> atomnuker, tried your dav1d msac branch, it is slower (than pure C) :(
[18:45:31 CET] <kurosu_> haven't looked at your branch, but msac_update_cdf is already vectorized
[18:45:36 CET] <kurosu_> bbl
[18:45:43 CET] <durandal_1707> clang?
[18:52:02 CET] <kurosu_> gcc 8.2/win64/msys2
[18:52:37 CET] <kurosu_> I wonder what would happen if I specified -mavx2 or stuff; I have already seen bmi insns in bitstream functions, in that case
[18:53:19 CET] <jamrial> how did you bench? atomnuker didn't add a checkasm test yet
[18:53:37 CET] <kurosu_> just runtime on a sequence
[18:55:14 CET] <kurosu_> 9.7s -> 10.5s
[18:57:29 CET] <jamrial> kurosu_: yeah, it is slower for me as well
[18:58:04 CET] <jamrial> 59fps to 56fps on this one 1080p sample
[18:58:37 CET] <BBB>     pand  m1, m2
[18:58:37 CET] <BBB>     pxor  m2, [inv_16bit]
[18:58:38 CET] <BBB>     pand  m0, m2
[18:58:40 CET] <BBB> atomnuker: pandn
[18:59:01 CET] <BBB> pandn m0, m2, m0 is the same as pxor m2, 0xfffffff.. and then pand m0, m2
[18:59:11 CET] <BBB> memory access is expensive
[19:01:12 CET] <BBB> you could also consider a mask to only update the bits within n_syms
[19:01:18 CET] <BBB> that way you dont need the weird alignment
[19:04:17 CET] <jamrial> psrlw using memory seems to read 16 bytes from it, and i'm not sure if that's what you inteded
[19:05:23 CET] <cone-796> ffmpeg 03BIGLER Don (Framatome) 07master:cb74c33106d0: avdevice/decklink_dec: fix codec_tag of RGBA formats
[19:05:23 CET] <cone-796> ffmpeg 03Anton Platov 07master:295fd12d17f3: avdevice/libndi_newtek_dec: add extra_ips option to libndi_newtek allowing use remote network sources
[19:09:51 CET] <BBB> atomnuker: want me to play around with that?
[19:10:09 CET] <BBB> atomnuker: and the C code works, right?
[19:13:08 CET] <atomnuker> kurosu_: yeah, it does 2 function calls instead of one and 2 memcpys
[19:14:40 CET] <BBB> thats why I suggested inline sse2
[19:14:43 CET] <BBB> so the function call is gone
[19:15:32 CET] <atomnuker> well, the functions will get bigger once updating is done at the same time as decoding
[19:15:48 CET] <atomnuker> so inlining won't really be doing good for the size at that point
[19:16:13 CET] <atomnuker> BBB: go and play with it, I tried pandn and it didn't work right away
[19:17:18 CET] <BBB> sure :)
[19:33:27 CET] <thardin> does ffmpeg needs hosting for things?
[19:33:53 CET] <thardin> local computer club has some 13 Gbps of unused bandwidth to spare for free software projects
[20:02:21 CET] <cone-796> ffmpeg 03Anton Platov 07n3.4.5:HEAD: avdevice/libndi_newtek_dec: add extra_ips option to libndi_newtek allowing use remote network sources
[20:14:56 CET] <durandal_1707> tpad is 411th filter
[20:23:46 CET] <philipl> BtbN: time to pester you about the yadif filter :-)
[20:24:39 CET] <BtbN> I haven't forgotten it, just insanely short on time at the moment
[20:26:02 CET] <BtbN> philipl, I'm also not sure who is responsible for yadiff to ok those changes.
[20:26:40 CET] <philipl> michaelni presumably?
[20:26:41 CET] <BtbN> it's just moving a bunch of functions without changes, so should be ok in general
[20:26:51 CET] <philipl> It seemed wasteful to duplicate them.
[20:27:01 CET] <philipl> I can also consolidate bwdif to reuse them with a small addition.
[20:27:06 CET] <BtbN> yeah, it's the right approach, just needs to be okayed
[20:27:35 CET] <JEEB> &41
[20:27:42 CET] <durandal_1707> michaelni: why cant release be named Carl? you are not friendly and ignore lots of votes
[20:29:11 CET] <jamrial> durandal_1707: because they are troll votes
[20:30:22 CET] <BtbN> philipl, I'm starting to wonder if we should put all those CHECK_CU stuff in some central place.
[20:30:35 CET] <BtbN> But that's something for another patch at some point
[20:30:53 CET] <philipl> Yeah. It can be done - just a little tedious to ensure naming is consistent, etc.
[20:31:20 CET] <durandal_1707> jamrial: troll votes? you can not be so serious
[21:07:35 CET] <durandal_1707> it is 11, 2018 and there are still AVERROR_EOF bugs in ffmpeg code
[21:09:03 CET] <philipl> There is no end to EOF.
[21:10:43 CET] <gnafu> EOEOF
[21:10:57 CET] <gnafu> "There was a coder, had a bug.  EOEOF."
[23:11:06 CET] <cone-124> ffmpeg 03Marton Balint 07master:6a034adf7516: avformat/ftp: return AVERROR_EOF for EOF
[23:19:55 CET] <cone-124> ffmpeg 03Marton Balint 07release/4.0:00e7e4b18806: avcodec/libx264: remove FF_CODEC_CAP_INIT_THREADSAFE flag
[23:19:56 CET] <cone-124> ffmpeg 03Marton Balint 07release/4.0:ebc01c8f6dfc: avformat/ftp: return AVERROR_EOF for EOF
[23:27:07 CET] <akravchenko188> jkqxz: Hello. I have sent updated patches for hwcontext_amf & amfenc. Could you please review them and apply if they are ok?
[23:55:30 CET] <philipl> BtbN: heh. That's a landmine of a function to add :-)
[23:56:05 CET] <BtbN> Yeah, I definitely do not want the full enum. Most of that is useless
[23:56:16 CET] <BtbN> CU_DEVICE_ATTRIBUTE_ECC_ENABLED... 
[00:00:00 CET] --- Fri Nov  2 2018