[Ffmpeg-devel-irc] ffmpeg-devel.log.20181103

[burek]

[01:17:09 CET] <cone-671> ffmpeg 03Michael Niedermayer 07release/4.0:d2ce6472a77a: avcodec/msrle: Check that the input is large enough to contain a end of picture code
[01:17:10 CET] <cone-671> ffmpeg 03Michael Niedermayer 07release/4.0:b8aa7b9a6d86: avutil/integer: Fix integer overflow in av_mul_i()
[01:17:11 CET] <cone-671> ffmpeg 03Michael Niedermayer 07release/4.0:fcbd117df307: Changelog: update
[01:50:03 CET] <cone-671> ffmpeg 03Michael Niedermayer 07n4.0.3:HEAD: avcodec/prosumer: Simplify bit juggling of the c variable in decompress()
[04:20:32 CET] <cone-671> ffmpeg 03James Almer 07release/4.0:dee8f4b01bfe: avcodec/libaomenc: remove AVOption related to frame partitions
[11:12:03 CET] <durandal_1707> who put yadif_cuda filter in wrong section of Changelog?
[13:01:01 CET] <atomnuker> BBB: wrote checkasm, how do I get the bench time?
[13:31:08 CET] <BBB> bench
[13:31:15 CET] <BBB> test=<yourtestname> --bench
[13:31:27 CET] <BBB> e.g. test=looprestoration_8bpc bench
[13:31:49 CET] <BBB> where the name is the one from the table in checkasm.c
[13:32:11 CET] <BBB> and then itll report everything that has a report() line under that function cll
[13:34:05 CET] <atomnuker> meson test -C build -v test=looprestoration_8bpc bench
[13:34:09 CET] <atomnuker> no suitable tests found
[13:34:50 CET] <atomnuker> then what's the string in check_func() used for if only the one in report() is used?
[13:35:09 CET] <atomnuker> you can give arguments to it, like cdf size, unlike in report
[13:35:19 CET] <BBB> ninja && tests/checkasm test=looprestoration_8bpc bench
[13:35:41 CET] <BBB> sorry, youre right
[13:35:49 CET] <BBB> check_func() is for the per-function perf benchmark (--bench)
[13:36:04 CET] <BBB> the report() is only to validate that all tests in that group passed
[13:36:30 CET] <BBB> and checkasm.c is for test=<name> selection
[13:36:50 CET] <atomnuker> zsh: permission denied: tests/checkasm
[13:37:09 CET] <atomnuker> oh damn, forgot to append build dir
[13:37:16 CET] <BBB> :)
[13:37:41 CET] <atomnuker> did I mention I hate meson and like obscure long bash scripts?
[13:37:48 CET] <BBB> o_O
[13:37:55 CET] <atomnuker> seems like every project but the simplest that uses meson is fighting against it
[13:37:57 CET] <BBB> I guess you did now :)
[13:38:25 CET] <atomnuker> people constantly need to add features to fix bugs, do workarounds to make it work
[13:38:25 CET] <BBB> j-b selected the build system and he liked this. Im fine with it, it does what it needs to do
[13:38:34 CET] <atomnuker> and at the end of the day there's no make backend
[13:38:45 CET] <atomnuker> why? make is fast, everyone has it, ninja is some google thing
[13:39:06 CET] <atomnuker> but they made it a principle not to have make support
[13:39:15 CET] <BBB> I dont care, I really dont. I dont care for build systems. I care for C code and assembly, and algorithms for video compression etc.
[13:39:35 CET] <atomnuker> yeah, I know, this is on the side of usability and extendability
[13:39:37 CET] <BBB> I ask dumb questions aboutt he build system all the time, and ePirat is knowledgable and answers all my questions
[13:39:41 CET] <BBB> so it works fine for me
[13:40:05 CET] <BBB> its better than ffmpegs configure, where nobodoy knows how it works, except mru who isnt here and diego whos doing some fork
[13:40:38 CET] <BBB> usability o_O whats that? :-p
[13:40:48 CET] <BBB> anyway, does checkasm work now?
[13:41:07 CET] <atomnuker> configure.sh is alright, I can sort of understand what it does enough to work with it
[13:41:08 CET] <BBB> dont forget to build in release mode
[13:41:17 CET] <atomnuker> and its also faster than meson and doesn't require ninja
[13:41:24 CET] <BBB> (meson configure --buildtype=release -Db_sanitize=none && ninja clean && ninja)
[13:41:24 CET] <atomnuker> granted, it doesn't support msvc though
[13:41:41 CET] <atomnuker> can't I use debugoptimized?
[13:41:43 CET] <JEEB> msvc it does, it doesn't support msvs
[13:41:51 CET] <JEEB> otherwise we wouldn't support cl.exe
[13:42:17 CET] <BBB> debugoptimized is probably ok, yes
[13:42:17 CET] <JEEB> (MSVS is the GUI/IDE, MSVC is the C compiler)
[13:42:25 CET] <BBB> release is slightlybetter but itll only be off by a few %
[13:42:32 CET] <BBB> dont use debug, its like -O0, results will be useless
[13:42:37 CET] <atomnuker> BBB: running the checkasm script and it prints exactly what meson test outputs
[13:42:47 CET] <atomnuker> debugoptimized isn't release + debug symbols?
[13:43:02 CET] <BBB> I think one is O2 and one is O3?
[13:43:17 CET] <BBB> $ tests/checkasm --test=looprestoration_8bpc
[13:43:17 CET] <BBB> checkasm: using random seed 4273947412
[13:43:19 CET] <BBB> AVX2:
[13:43:20 CET] <BBB>  - looprestoration_8bpc.wiener [OK]
[13:43:21 CET] <BBB>  - looprestoration_8bpc.sgr    [OK]
[13:43:22 CET] <BBB> checkasm: all 5 tests passed
[13:43:24 CET] <BBB> you dont see that?
[13:43:40 CET] <atomnuker> nope, I see checkasm: all 1068 tests passed
[13:43:53 CET] <atomnuker> ./build/tests/checkasm test=looprestoration_8bpc bench
[13:44:03 CET] <BBB> did you copypaste my dashes?
[13:44:17 CET] <BBB> my irc client converts them from a real dash to some corrupt counterpart
[13:44:22 CET] <BBB> which isnt an actual dash
[13:44:24 CET] <atomnuker> ...I did
[13:44:30 CET] <BBB> really
[13:44:33 CET] <BBB> and still nothing?
[13:44:44 CET] <atomnuker> no, I mean I copied them and that's why it didn't work
[13:44:47 CET] <BBB> :)
[13:44:54 CET] <BBB> sorry, my irc client is & dumb
[13:45:07 CET] <BBB>  - -
[13:45:10 CET] <atomnuker> your dots and quote marks are visibly different here, but dashes not so much
[13:52:55 CET] <BBB> you know we have a irc channel for this where other people can also help with these questions, right? just sayin. you dont have to be there if you dont want to, but youd get answers quicker
[13:56:28 CET] <atomnuker> yeah, I know, I'm in no hurry and I don't know what else to do after the ec stuff is done
[13:58:47 CET] <BBB> theres a long todo list of potential funny optimizations on the wiki
[13:58:58 CET] <BBB> https://code.videolan.org/videolan/dav1d/wikis/task-list
[13:59:14 CET] <BBB> youd maybe be interested in the more technical ones?
[13:59:35 CET] <BBB> e.g. the palette index context optimizations, the hi/lo coef coding context optimizations
[13:59:44 CET] <BBB> esp. the second could be pretty big if we do it right
[13:59:49 CET] <BBB> brb
[16:11:09 CET] <ePirat> atomnuker, yes meson has still some rough edges and lacking support of some things in some areas but it's improving
[16:55:44 CET] <cone-077> ffmpeg 03Josh de Kock 07master:8096f52049ac: fate/api-h264-slice-test: don't use ssize_t
[16:55:44 CET] <cone-077> ffmpeg 03Josh de Kock 07master:1052578dadf7: fate/api-h264-slice-test: use cleaner error handling
[16:58:11 CET] <nevcairiel> January: can you push that to 4.1 as well?
[16:58:44 CET] <cone-077> ffmpeg 03Josh de Kock 07release/4.1:5060a615c738: fate/api-h264-slice-test: don't use ssize_t
[16:58:45 CET] <cone-077> ffmpeg 03Josh de Kock 07release/4.1:765fb1f224f6: fate/api-h264-slice-test: use cleaner error handling
[17:01:50 CET] <jamrial> nevcairiel: why didn't the ssize_t error happen in your fate clients?
[17:01:55 CET] <nevcairiel> it does
[17:02:10 CET] <nevcairiel> but compile errors in test programs dont get recognized by fate as a failure for some reason
[17:02:25 CET] <jamrial> ah
[17:02:37 CET] <jamrial> yeah, i've seen that happen before with other tests
[17:02:40 CET] <nevcairiel> fatebeta shows the stations as yellow
[17:02:42 CET] <jamrial> it's really annoying
[17:02:47 CET] <nevcairiel> but for some reason fatebeta was never finished
[17:03:27 CET] <jamrial> it's yellow but still says "3660 / 3660"
[17:03:33 CET] <jamrial> so not perfect
[17:03:41 CET] <nevcairiel> yeah but at l east it indicates something is wrong
[18:12:00 CET] <gaara4896> Hello, I was trying to compile ffmpeg, and I face this problem. The config.log looks something like this: https://pastebin.com/DUzgv9W6, but libstegolib.so did exists inside the folder ffmpeg/lib/libstegolib.so, anyone have any idea what might be the cause?
[18:12:24 CET] <JEEB> that is not related to upstream as I already told you on #ffmpeg
[18:12:45 CET] <JEEB> please do not spam and this channel is specific to FFmpeg development
[18:25:36 CET] <cone-077> ffmpeg 03Paul B Mahol 07master:639694eaa554: avfilter/vf_extractplanes: use ff_outlink_get_status()
[18:25:37 CET] <cone-077> ffmpeg 03Paul B Mahol 07master:decc008929e3: avfilter/af_amultiply: make use of ff_inlink_queued_samples()
[18:25:38 CET] <cone-077> ffmpeg 03Paul B Mahol 07master:4b82b7104120: avfilter/af_amerge: use ff_inlink_queued_samples()
[18:25:39 CET] <cone-077> ffmpeg 03Paul B Mahol 07master:c8625e5c6f50: avfilter/af_afade: do not use framequeue directly
[18:25:40 CET] <cone-077> ffmpeg 03Paul B Mahol 07master:242f7bf20254: avfilter/split: use ff_outlink_get_status()
[18:25:51 CET] <JEEB> -34
[20:36:42 CET] <durandal_1707> SSSSSSSSSSSSSSSPPPPPPPPPPPPPPPPPPAAAAAAAAAAAAAAAAAAAAAAAAAAAAMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
[20:37:53 CET] <atomnuker> where?
[20:38:43 CET] <durandal_1707> philipl: did you put cuda yadif filter in wrong section of Changelog?
[20:42:38 CET] <durandal_1707> atomnuker: spam of silence
[20:50:16 CET] <atomnuker> it is saturday after all
[20:51:31 CET] <atomnuker> I have learned to appreciate silence more over the past few days
[20:51:47 CET] <atomnuker> there has been constant bombardment here over the past week or more here
[20:52:54 CET] <atomnuker> fireworks, explosions, around the evenings, some foreign holiday or something which last a whole 2 weeks or so
[20:53:27 CET] <atomnuker> oh and a fucking bird that sings for 5 minutes at 06:36 every morning, wakes me up, and fucks off a few minutes later
[20:56:38 CET] <philipl> durandal_1707: did i?
[20:58:41 CET] <Compn> lol atomnuker
[20:58:47 CET] <Compn> 6:36 bird
[21:05:21 CET] <philipl> i thought 4.0 had been cut already. is it not?
[21:05:40 CET] <nevcairiel> 4.1 has been cut yes
[21:06:04 CET] <nevcairiel> but thats why its in the wrong section
[21:06:08 CET] <nevcairiel> because its not in 4.1 =p
[21:06:09 CET] <atomnuker> Compn: yes, it thinks its spring, the small idiotic creature, and thus sings as if its the breeding season
[21:06:13 CET] <philipl> oh.
[21:06:26 CET] <nevcairiel> generally, you always put it into the top section, it gets updated on cuts
[21:06:26 CET] <atomnuker> its not as bad as spring though, fuck spring, multiple ones all at once at 05:20
[21:06:48 CET] <philipl> well, that's easy to fix. or do you want me to cherry pick it over?
[21:07:01 CET] <nevcairiel> i wouldnt mind having it in 4.1
[21:07:06 CET] <nevcairiel> its not like 4.1 is frozen yet
[21:07:17 CET] <philipl> i missed it because when i started, 4.1 hadn't been cut yet.
[21:07:33 CET] <philipl> i'll cherry-pick it over later today.
[23:46:42 CET] <philipl> nevcairiel: So what do I do about the version.h when porting to the branch?
[23:46:59 CET] <philipl> I have a minor bump because of the new filter. Do I just leave it untouched? Increase the micro version instead?
[23:47:38 CET] <nevcairiel> do a micro i guess
[23:49:32 CET] <philipl> Will do
[23:55:18 CET] <cone-077> ffmpeg 03Philip Langdale 07release/4.1:041231fcd632: libavfilter/vf_yadif: Make frame management logic and options shareable
[23:55:19 CET] <cone-077> ffmpeg 03Philip Langdale 07release/4.1:67126555fc03: avfilter/vf_yadif_cuda: CUDA accelerated yadif deinterlacer
[23:55:20 CET] <cone-077> ffmpeg 03Philip Langdale 07release/4.1:6feec11e489b: avcodec/nvdec: Increase frame pool size to help deinterlacing
[23:55:21 CET] <cone-077> ffmpeg 03Philip Langdale 07release/4.1:ebc1c49e417c: avfilter/vf_cuda_yadif: Avoid new syntax for vector initialisation
[00:00:00 CET] --- Sun Nov  4 2018