[Ffmpeg-devel-irc] ffmpeg-devel.log.20181007

[burek]

[03:08:03 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:ad89e203bfed: avcodec/unary: Improve get_unary() docs
[03:08:03 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:8c49340b189f: libavformat/ty: use decimal constant for shift
[03:08:03 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:52e62b0585c1: avformat/movenc: Remove unneeded variable from mov_find_codec_tag()
[03:08:03 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:8dd7c2c6a71b: avfilter/af_aiir: Remove l from %lf in av_log environment
[03:08:03 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:64144158890b: avfilter/af_biquads: Remove l from %lf in av_log environment
[03:08:03 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:1a7a17fb75e8: libavcodec/v4l2_buffers.h: fix cant typos
[03:08:03 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:1fc3d8ee004a: avcodec/vc1_loopfilter: Fix colums typos
[03:08:04 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:c07bbdbcf051: avfilter/vf_tonemap_opencl: Fix seperate typo
[03:08:05 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:fd3eda40308e: avcodec/speedhq: Make speedhq_vlc const
[03:08:06 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:beb3aea48e5f: avformat/utils: Do not ignore failure in extract_extradata_init()
[03:08:07 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:b4a1ccfc4161: avformat/utils: Do not use "i" as a context pointer, "i" is normally the integer counter in loops
[03:08:08 CEST] <cone-926> ffmpeg 03Michael Niedermayer 07master:0a41a8bf2945: avformat/utils: Fix potential integer overflow in extract_extradata()
[05:23:28 CEST] <philipl> BtbN: reminder about header updates, and: https://github.com/philipl/FFmpeg/commits/master for the hevc 444 stuff.
[10:06:47 CEST] <durandal_1707> michaelni: stop adding regressions with your "security" fixes !
[10:26:41 CEST] <BtbN> philipl, can you make it optionally load those functions, so it doesn't bump the driver requirement? It should be fairly easy to add runtime checks for the functions to exist.
[10:41:17 CEST] <BtbN> There's already a macro for that that's used for one cuvid function
[10:52:57 CEST] <BtbN> I also still think ffmpeg should gain a pix_fmt that has the right padding for most hw de/encoders. Yes, it's annoying, but that's how it is now.
[11:02:43 CEST] <atomnuker> I think LSB padding makes more sense anyway
[11:04:21 CEST] <BtbN> It's the one that enables you to just straight up use 10 bit as 12 or 16 bit I think?
[11:04:44 CEST] <nevcairiel> the beauty of that padding is that you really dont need more then two formats
[11:04:44 CEST] <BtbN> Which is exactly what the nvidia hardware does
[11:04:49 CEST] <nevcairiel> one for 8, one for 16
[11:05:05 CEST] <nevcairiel> and you can square away the difference with an additional bitdepth argument
[11:05:09 CEST] <nevcairiel> just like eg. audio
[11:05:42 CEST] <BtbN> For ffmpeg that would still mean 3 new pix_fmts, even though they are technically identical, there is no other way to signal 10, 12 or 16 bits
[11:17:54 CEST] <atomnuker> what for? extra info to do proper dithering?
[11:23:45 CEST] <BtbN> Selecting the right encoder mode for example.
[11:23:56 CEST] <BtbN> Otherwise it will always think it's getting 16 bit
[11:24:54 CEST] <BtbN> We used to just use the 16bit format everywhere, but there were issues with that, and it was patched out
[11:31:34 CEST] <atomnuker> ah, right
[11:32:03 CEST] <nevcairiel> using an additional bitdepth argument would still be better tho
[11:35:13 CEST] <atomnuker> we have one but its in avctx, not in avframes
[11:38:19 CEST] <BtbN> An extra bit depth argument would seem confusing to me, given how the whole rest of ffmpeg communicates that via the pix_fmt
[11:40:17 CEST] <nevcairiel> it only does that because noone bothered to clean it up p roperly
[11:40:40 CEST] <nevcairiel> when all formats have identical layout anyway, using a bitdepth argument seems superior to me
[11:41:29 CEST] <BtbN> True. It's just the P16 variant. So the bitdepth argument would just have to be added to AVFrame, and maybe some other places.
[11:41:42 CEST] <BtbN> If it's unset, assume 16 bit, or whatever the format says
[11:42:54 CEST] <nevcairiel> audio uses avctx->bits_per_raw_sample for that same purpose, ie. 20 and 24-bit audio is all put into S32 format
[11:43:00 CEST] <nevcairiel> but yeah its not in avframe apparently
[12:18:52 CEST] <BtbN> atomnuker, I can't see a bit depth in AVCodecContext either?
[12:19:10 CEST] <nevcairiel> see two lines above, its bits_per_raw_sample
[12:19:44 CEST] <nevcairiel> * Bits per sample/pixel of internal libavcodec pixel/sample format.
[12:19:48 CEST] <nevcairiel> even has the proper docs
[12:20:01 CEST] <cone-339> ffmpeg 03Paul B Mahol 07master:9c120b4d4201: avfilter/avf_showspectrum: add legend support to showspectrum filter
[12:20:10 CEST] <BtbN> oh, thought that only applied to audio
[12:20:19 CEST] <nevcairiel> its only really used for audio now
[12:20:34 CEST] <nevcairiel> but no reason to make another one
[12:20:46 CEST] <BtbN> yeah, it matches video just fine
[12:21:12 CEST] <BtbN> Does audio just not communicate it on a per-frame level at all?
[12:21:19 CEST] <nevcairiel> apparently not
[12:21:52 CEST] <BtbN> Tempting to just copy bits_per_raw_sample over there
[12:22:10 CEST] <nevcairiel> could use a rename, that name is a bit weird
[12:23:01 CEST] <BtbN> A bit on the audio side of things
[12:23:17 CEST] <BtbN> It does describe the meaning of the field pretty well though
[12:26:27 CEST] <atomnuker> well having a per-frame bits per sample would go part of the way to simplifying
[12:26:33 CEST] <BtbN> A problem I see is format selection for encoders. How would for example nvenc communicate that it cannot take 12 and 16 bit, but only 10 bit on 444P16
[12:26:51 CEST] <atomnuker> a new field to indicate accepted bit depths?
[12:27:03 CEST] <atomnuker> like encoder's acceptable samplerates
[12:27:06 CEST] <BtbN> The accepted bit depths vary per pix fmt
[12:27:16 CEST] <JEEB> yea, they'd have to be in a struct
[12:27:21 CEST] <JEEB> pic_fmt + bit depth
[12:27:32 CEST] <BtbN> Or a callback querying if it's supported
[12:27:37 CEST] <JEEB> yea
[12:28:14 CEST] <BtbN> I still feel like just adding those padded formats as new pix_fmts would be less error prone
[12:28:35 CEST] <JEEB> yes, it would be the simplest way out according to what we have at the moment, that I do agree on
[12:29:39 CEST] <JEEB> also this somehow reminded me that I wanted to make libx264 update its colorspace information according to AVFrames fed in encode()
[12:29:48 CEST] <JEEB> I tried to do that earlier but never got it to work
[12:30:19 CEST] <JEEB> since after init() you still haven't written anything, so in theory if you get the data only at encode() it should still be possible :V
[16:40:25 CEST] <philipl> BtbN: ok. I'll look at conditional loading.
[16:41:09 CEST] <BtbN> It's just a minimal change, there's a macro for it, and then one check before using them
[16:41:28 CEST] <philipl> What's the punchline on the pix fmt stuff? Are you with it as just P16 or do you want the pixfmts added?
[16:41:43 CEST] <BtbN> I kinda want them added, everything else seems like a horrible mess
[16:42:14 CEST] <BtbN> Using an additional varible to indicate the bitness would make sense, but it would involve a huge bunch of code changes all over the place, even down into client apps
[16:42:32 CEST] <BtbN> a couple new _LSB pix fmts don't seem so bad in comparison
[16:42:42 CEST] <JEEB> and at that point you might as well go for structs
[16:42:47 CEST] <philipl> yeah. and I don't want to block this work on doing that.
[16:43:03 CEST] <philipl> ok.
[17:38:39 CEST] <philipl> BtbN: Updated the header diff. I'll push if you're happy
[17:42:11 CEST] <BtbN> yeah, looks ok
[17:43:42 CEST] <philipl> Thanks.
[17:43:52 CEST] <cone-701> ffmpeg 03Paul B Mahol 07master:3d308746eb45: avfilter/af_afade: add logistic sigmoid curve
[17:48:32 CEST] <philipl> done
[19:26:17 CEST] <philipl> BtbN: remind me what the scenario is where the copy-to-main-memory path is taken inside cuviddec? I need to test my changes here.
[19:26:25 CEST] <philipl> I can't get it to trigger.
[19:27:04 CEST] <philipl> It seems to also end up using the hwcontext transfer path
[19:27:09 CEST] <philipl> s/also/always/
[19:39:59 CEST] <durandal_1707> i have nothing left to do/play
[19:45:35 CEST] <jamrial> durandal_1707: give yuvj a killing blow
[19:46:17 CEST] <durandal_1707> i wish i could, but there is strong oposition
[19:47:03 CEST] <BtbN> philipl, when not CUDA is requested from it.
[19:47:10 CEST] <BtbN> Not passing any hwaccel to ffmpeg.c should do that?
[19:49:51 CEST] <jamrial> durandal_1707: what oposition? other than reported regressions in some command lines i haven't seen people against it
[19:50:07 CEST] <JEEB> yea I don't think people are against it at all
[19:50:14 CEST] <JEEB> it's just that fixing all the issues is gonna need busywork
[19:52:56 CEST] <atomnuker> yeah, no one objected afaik, koda mentioned that he'd like every single property to be negotiated (iirc) but having yuvj removed goes part of the way
[19:55:30 CEST] <durandal_1707> libswscale becomes monstrosity
[19:57:16 CEST] <atomnuker> it needs to get replaced anyway
[19:58:00 CEST] <durandal_1707> atomnuker: replaced? with what? don't be funny!
[20:01:23 CEST] <philipl> BtbN: Thanks. So my copy-out logic in the patchset isn't right yet.
[20:40:29 CEST] <cone-701> ffmpeg 03Marton Balint 07master:0e9a09793a98: avfilter/af_afade: fix crossfade duration maximum value
[20:40:31 CEST] <cone-701> ffmpeg 03Marton Balint 07master:3bfd409e59e8: avformat/segment: fix segment_time_delta option min/max value
[20:40:31 CEST] <cone-701> ffmpeg 03Marton Balint 07master:d40dc64173a1: avutil/opt: check for minimum and maximum values when setting AV_OPT_TYPE_DURATION fields
[20:40:32 CEST] <cone-701> ffmpeg 03Marton Balint 07master:4c777d52b9b1: avutil/parseutils: fix some overflows in duration calculations
[20:40:33 CEST] <cone-701> ffmpeg 03Marton Balint 07master:416804fe4120: avutil/tests/parseutils: add some big duration tests
[20:45:24 CEST] <cone-701> ffmpeg 03Dave Rice 07master:1431ff2d379e: ffplay: add options to specify window position
[21:39:58 CEST] <BtbN> philipl, I'll wait for confirmation of the next pix_fmts first.
[22:59:15 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:1a4a6d94ccb9: avutil/pixfmt: Document chroma plane size for odd resolutions
[22:59:16 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:cec6df48ba89: swresample/swresample: Fix input channel count in resample_first computation
[22:59:17 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:f291acafbb30: avcodec/diracdec: Prevent integer overflow in intermediate in global_mv()
[22:59:18 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:8147da2bad1b: avcodec/dirac_dwt_template: Fix several integer overflows in horizontal_compose_daub97i()
[22:59:19 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:88093d2c1fbb: avcodec/diracdec: Change frame_number to 64bit as its a 32bit from the bitstream and we also have a -1 special case
[22:59:20 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:6cf72a56e7e6: avcodec/diracdec: Check slice numbers for overflows in relation to picture dimensions
[22:59:21 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:4f51a21c30c6: avcodec/diracdec: Check bytes count in else branch in decode_lowdelay() too
[22:59:22 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:f9235773d60b: avcodec/qtrle: Check remaining bytestream in qtrle_decode_XYbpp()
[22:59:23 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:07255282d0ba: avcodec/mlp_parser: Check if synccode is within buffer
[22:59:24 CEST] <cone-701> ffmpeg 03Nikolas Bowe 07release/4.0:8591d16ce5f8: lavc/svq3: Fix regression decoding some files.
[22:59:25 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:386975d7a4aa: avformat/flvenc: Check audio packet size
[22:59:26 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:cc0817af0d66: avcodec/aacpsdsp_template: Fix integer overflow in ps_stereo_interpolate_c()
[22:59:27 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:c0a6febf3231: avcodec/mpegaudio_parser: Initialize poutbuf*
[22:59:28 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:2c3ea340826a: avcodec/shorten: Check verbatim length
[22:59:29 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:32353f8bcbb4: avcodec/shorten: Fix integer overflow in residual/LPC combination
[22:59:30 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:cd42c19f53de: avcodec/shorten: Fix signed 32bit overflow in shift in shorten_decode_frame()
[22:59:31 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:b95c209a6108: avcodec/scpr: Check for min > max in decompress_p()
[22:59:32 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:3f095c5b56ba: avformat/rmdec: Fix EOF check in the stream loop in ivr_read_header()
[22:59:33 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:0f36c5f5c776: avformat/mlvdec: read_string() received unsigned size, make the argument unsigned
[22:59:34 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:f2b51fd54c44: avformat/dashdec: Fix strlen(rep_id_val) with it being NULL
[22:59:35 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:6e60a38322d1: avformat/nsvdec: Do not parse multiple NSVf
[22:59:36 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:ce828a247d5f: avcodec/mpeg4videodec: Fix slice end detection in mpeg4_decode_studio_mb()
[22:59:37 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:a04ff0c054e8: avcodec/snowdec: Fix integer overflow with motion vector residual
[22:59:38 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:229025799f62: avcodec/vb: Check for end of bytestream before reading blocktype
[22:59:39 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:8327559fe80d: avcodec/hq_hqa: Check remaining input bits in hqa_decode_mb()
[22:59:40 CEST] <cone-701> ffmpeg 03Michael Bunk 07release/4.0:84ab680624e8: examples: Fix use of AV_CODEC_FLAG_GLOBAL_HEADER
[22:59:41 CEST] <cone-701> ffmpeg 03Dale Curtis 07release/4.0:968ffb93af04: avformat/mov: Error on too large stsd entry counts.
[22:59:42 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:17a5df4ab8c6: avcodec/indeo4: Check dimensions in decode_pic_hdr()
[22:59:43 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:318b13a5adb3: avcodec/ra144: Fix undefined integer overflow in add_wav()
[22:59:44 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:7da37aa9804a: avcodec/h264_refs: Document last if() in ff_h264_execute_ref_pic_marking()
[22:59:45 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:9afcf994f6f7: avcodec/dvdsubdec: Avoid branch in decode_run_8bit()
[22:59:46 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:6d2b2ee3a53a: avcodec/shorten: Fix bitstream end check in read_header()
[22:59:47 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:5af88171e738: avcodec/zmbv: Update decomp_len in raw frames
[22:59:48 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:47f608a7e146: avcodec/zmbv: Check that the decompressed data size is correct
[22:59:49 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:5a4234de5eb3: avcodec/mpeg4videodec: Fix undefined shift in get_amv()
[22:59:50 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:1a05e6ced3dc: avcodec/dvdsubdec: Sanity check len in decode_rle()
[22:59:51 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:f645fd64c3f3: doc/examples/vaapi_transcode: Fix the typo
[22:59:52 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:45fb50b4bc5d: avcodec/eac3dec: Check that channel_map does not contain more than EAC3_MAX_CHANNELS
[22:59:53 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:d7973cf03d07: avcodec/ac3dec: Fix shift signedness in mask creation
[22:59:54 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:531ebb7506fd: avcodec/gdv: Replace divisions by shifts in rescale()
[22:59:55 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:7f521fae2b1f: avcodec/unary: Improve get_unary() docs
[22:59:56 CEST] <cone-701> ffmpeg 03Michael Niedermayer 07release/4.0:eb495b20e51f: avformat/utils: Fix potential integer overflow in extract_extradata()
[23:07:11 CEST] <philipl> BtbN: K.
[00:00:00 CEST] --- Mon Oct  8 2018