[Ffmpeg-devel-irc] ffmpeg-devel.log.20181014

[burek]

[00:10:19 CEST] <nevcairiel> i didnt really follow the internal design that much
[00:18:08 CEST] <BtbN> I mean just the > vs. >= check of the buffer
[02:37:10 CEST] <philipl> BtbN: makes sense to me. Did you run into an actual problem?
[10:23:47 CEST] <BtbN> philipl, someone sent me this: https://bpaste.net/show/dea41479ae2b
[10:24:35 CEST] <BtbN> Aparently because there is _some issue_ when deinterlacing and seeking/flushing. I wasn't able to reproduce it, but the logic in is_buffer_full did seem a bit flawed to me, and it makes more sense to adjust there than making the queues larger than advertised
[10:26:25 CEST] <BtbN> "
[10:26:26 CEST] <BtbN> Unfortunatly FFMEG has a bug with deinterlacing cuda frames. So you have to patch the file in libavcodec/cuviddec.c
[10:26:26 CEST] <BtbN> Somewhere near line 360 depending on your release: old: ctx->frame_queue = av_fifo_alloc(ctx->nb_surfaces * sizeof(CuvidParsedFrame));
[10:26:26 CEST] <BtbN> new: ctx->frame_queue = av_fifo_alloc((ctx->nb_surfaces + 2 ) * sizeof(CuvidParsedFrame));
[10:26:26 CEST] <BtbN> "
[10:26:34 CEST] <BtbN> great copy&paste...
[10:27:24 CEST] <BtbN> Also nice that nobody ever filed a bug or anything about this in what seems to be over a year
[14:18:25 CEST] <cone-775> ffmpeg 03Michael Niedermayer 07master:fa7289e718e4: fate: Update checksums for recent mxf changes
[14:20:08 CEST] <cone-775> ffmpeg 03Paul B Mahol 07master:40c4b9dad0f8: avcodec/imm4: improve decoding of some files
[16:29:06 CEST] <philipl> BtbN: ok. change looks fine.
[16:29:26 CEST] <BtbN> I'd like them to test it, but they don't seem to react to my mail
[17:49:04 CEST] <JEEB> jamrial: I think the difference between HEVC in FLV and AVC/HEVC in IVF is that the latter was actually "used" by upstream, albeit in a manner that's internal only. so while they're different I do agree with the point. Maybe it's just simpler to say no :P
[17:49:39 CEST] <JEEB> simpler to have a muxer that takes it in but then gives a fat warning that this will only work with Google's internal systems
[17:52:25 CEST] <nevcairiel> also IVF has a proper fourcc
[17:52:32 CEST] <nevcairiel> so it really doesnt matter much
[17:52:44 CEST] <nevcairiel> FLV has a numeric index, that absolutely needs specification or it never works
[17:53:37 CEST] <JEEB> "*simpler than... " for the latter sentence
[18:12:53 CEST] <cone-545> ffmpeg 03Timo Rothenpieler 07master:19546cfef103: avcodec/cuviddec: properly take deinterlacing and display delay into account for buffer_full check
[18:20:14 CEST] <cone-545> ffmpeg 03Timo Rothenpieler 07release/4.0:7b23dd0f41bc: avcodec/cuviddec: properly take deinterlacing and display delay into account for buffer_full check
[18:28:40 CEST] <cone-545> ffmpeg 03Timo Rothenpieler 07release/3.4:e225db5d758c: avcodec/cuviddec: properly take deinterlacing and display delay into account for buffer_full check
[18:41:04 CEST] <cone-545> ffmpeg 03Timo Rothenpieler 07release/3.3:5c98f8d80a50: avcodec/cuviddec: properly take deinterlacing and display delay into account for buffer_full check
[23:44:16 CEST] <atomnuker> "Tink is a crypto library written by a group of cryptographers and security engineers at Google."
[23:44:33 CEST] <atomnuker> a certificate of quality
[23:55:15 CEST] <nevcairiel> for its security certainly, but those people usually cant code for shit :P
[00:00:00 CEST] --- Mon Oct 15 2018