[Ffmpeg-devel-irc] ffmpeg-devel.log.20190210

[burek]

[01:00:23 CET] <BtbN> So OBS completely duplicated another nvenc encoder, just to be able to pass in d3d11 textures.
[01:00:33 CET] <BtbN> Guess it's not very clear that's possible to do with libavcodec
[01:03:23 CET] <JEEB> yea
[01:04:21 CET] <BtbN> Though passing in already existing textures actually is very hard, as they pretty much HAVE to be allocated by a hw_frames_ctx
[01:04:31 CET] <BtbN> So you need to setup a fake one
[01:05:03 CET] <BtbN> not sure how that works on the d3d11 end though
[01:05:14 CET] <JEEB> also funky, ARIB strings mostly start with 0xe (14) and 0xf (15) so in theory this new conversion in mpegts.c should leave them alone. Except it doesn't for this one sample's mobile program.
[01:07:13 CET] <JEEB> https://kuroko.fushizen.eu/samples/nhk_linux_sample.ts
[01:08:10 CET] <JEEB> the initial byte seems to get cut off from the mobile one. wonder if I'll just have to make a separate mode for ARIB demuxing mode
[01:09:11 CET] <JEEB> as in, an explicit if (mode == MPEGTS_MODE_ARIB) else current_code
[02:58:01 CET] <cone-296> ffmpeg 03Jan Ekström 07master:100bfac6d6ec: add libaribb24 ARIB STD-B24 caption decoder
[02:58:01 CET] <cone-296> ffmpeg 03Jan Ekström 07master:a03885b745be: lavf/mpegts: add reading of ARIB data coding descriptor
[02:58:11 CET] <JEEB> there
[02:58:21 CET] <JEEB> I waited 48h and there were no further objections
[02:58:28 CET] <JEEB> (carl's was non-blocking)
[03:17:09 CET] <agrecascino> i made a new patch
[07:46:31 CET] <cone-632> ffmpeg 03Steven Liu 07master:9ec1f7634a62: avformat/hlsenc: fix fmp4_init_filename file name with %v problem
[07:47:53 CET] <cone-632> ffmpeg 03Reto Kromer 07master:d20902fd2399: doc/filters: fix typos
[12:41:23 CET] <j-b> durandal_1707: do you support IMM5?
[12:42:26 CET] <durandal_1707> j-b: i had some WIP patch, but gave up to work on that crap codec
[12:43:44 CET] <j-b> ok
[12:43:52 CET] <j-b> Too hard? Too weird?
[12:46:25 CET] <durandal_1707> j-b: it just shortens some NALs by hardcoding them into some funky codes. It is ripped H264.
[12:46:54 CET] <j-b> So much not supririnsg
[13:19:04 CET] <durandal_1707> ac4_toc() done, now remain hard part - actual parsing of audio data
[16:44:50 CET] <cone-829> ffmpeg 03Moritz Barsnick 07master:885a80d18969: doc: fix various typos
[16:47:10 CET] <cone-829> ffmpeg 03Reto Kromer 07master:21858b060fd9: doc/snow: fix typos
[17:57:02 CET] <cone-829> ffmpeg 03Carl Eugen Hoyos 07master:826cc58debfe: lavf/img2dec: Split img2 and img2pipe options.
[18:56:37 CET] <tmm1> can decoders set metadata or is sidedata the only way to return non-packet data
[18:58:29 CET] <JEEB> I thought AVFrames could have metadata? or was that AVPacket-only?
[18:58:38 CET] <cone-829> ffmpeg 03Carl Eugen Hoyos 07master:6de396c2168e: lavf/img2: Move "loop" into common options.
[19:00:22 CET] <durandal_1707> AVFrame metadata is AVDictionary
[19:02:07 CET] <tmm1> i'm trying to figure out what to do with ATSC XDS data like program name and rating
[19:03:00 CET] <tmm1> unfortunately its part of a53cc so i can only decode it inside ccaption_dec which returns subtitle frames
[19:06:36 CET] <JEEB> right
[19:06:38 CET] <JEEB> AVSubtitle
[19:07:07 CET] <durandal_1707> that is still not converted to AVFrame
[19:07:42 CET] <JEEB> yea, there's been some work done on that but it's not yet done
[19:08:15 CET] <tmm1> okay i see, i assumed it was the same as audio/video
[19:10:12 CET] <JEEB> talking of subtitles, I need to fix ASS encoder/muxer to handle multiple lines in AVSubtitle
[19:10:29 CET] <JEEB> implementing that in ARIB captions for positioning made me realize it was all borked
[19:14:21 CET] <tmm1> so AVSubtitle doesnt even have sidedata or metadata
[19:14:32 CET] <JEEB> yes, it's very much older and different
[19:14:48 CET] <JEEB> sounds like you want to co-operate with ubitux 
[19:14:55 CET] <JEEB> he was the one doing the AVFrame conversion
[19:30:33 CET] <tmm1> well there might not even be subtitles so trying to attach video stream metadata to the subtitle stream doesnt make much sense
[19:32:38 CET] <JEEB> yes, these things relate to the AVProgram so it's all a problem of how things are set up
[19:34:21 CET] <tmm1> ah right, thats where all the dvb details end up too
[19:40:17 CET] <tmm1> i thought i had seen some dvb samples where ffmpeg pulled out the channel/program name, but i can't find them now
[19:42:27 CET] <JEEB> channel/provider yes
[19:44:02 CET] <tmm1> how does ffmpeg -i display it? 
[19:44:58 CET] <JEEB> ffprobe -v verbose https://kuroko.fushizen.eu/samples/tbs_sample.ts
[19:45:03 CET] <JEEB> try that
[19:45:21 CET] <JEEB> will not show the stuff correctly but yunno - it's something
[19:56:19 CET] <durandal_1707> we should forbid travelers on behalf of FFmpeg project, they are doing nothing
[19:57:09 CET] <durandal_1707> self promotion usually only happens
[20:07:58 CET] <JEEB> man, on macs it becomes really evident that git's bash completion is something you want to have
[20:08:33 CET] Action: JEEB adds getting the bash completion script from git's release into his macOS setup steps
[20:08:49 CET] <durandal_1707> why you do not use shortcut/aliases ?
[20:09:08 CET] <JEEB> that's not the same
[20:09:16 CET] <JEEB> of course it adds auto-completion for commands
[20:09:23 CET] <JEEB> but it also autocompletes branches and remotes
[20:09:28 CET] <JEEB> as well as other things
[20:09:30 CET] <JEEB> it's just useful
[20:09:40 CET] <JEEB> and options
[20:37:34 CET] <tmm1> thanks, looks like its inside AVProgram.metadata
[20:38:18 CET] <tmm1> that's a good place for channel/provider, but not necessarily program name/info which can change without the mpegts program id changing
[20:38:56 CET] <JEEB> let me see how that one anonymous guy implemented that
[20:39:16 CET] <JEEB> now that I got ARIB caption demuxing in I'm going to attempt to bring his lavc decoder in for the format
[20:41:05 CET] <JEEB> https://github.com/0p1pp1/FFmpeg/commit/b230101325dacf8baa62f3d6da48f9aeb8647061
[20:41:12 CET] <JEEB> https://github.com/0p1pp1/FFmpeg/commit/29ec522896eb716adba333dcd49f9decd9d45ab4
[20:41:20 CET] <JEEB> so that's how he seems to be doing it
[20:42:14 CET] <tmm1> yea probably the most reasonable approach
[20:43:03 CET] <JEEB> I'm really sad this guy never contacted upstream
[20:43:08 CET] <JEEB> he seems to have a lot of interesting stuff
[20:43:30 CET] <tmm1> can i get to AVProgram* from inside a decoder?
[20:43:49 CET] <JEEB> right, that's the problem for you
[20:44:05 CET] <JEEB> so you have to start putting decoders within the demuxing or application layer
[20:44:46 CET] <tmm1> yep. maybe a better approach is to write it as a bsf and pull out into pkt side data
[20:47:11 CET] <tmm1> even though it really should be a decoder
[20:48:03 CET] <JEEB> the problem with these things is that broadcast likes to mish-mash abstraction layers
[20:48:07 CET] <JEEB> put X into Y etc
[20:53:04 CET] <tmm1> scte35 uses a new stream of AVMEDIA_TYPE_DATA, i could maybe do that and return each parsed XDS packet with its decoded contents attached as metadata
[21:14:17 CET] <jamrial> jkqxz: check the patch i just sent if you can
[21:19:49 CET] <jkqxz> Maybe that check should be moved out to the caller instead?
[21:22:56 CET] <jkqxz> The spec requires that nbBits is greater than zero in trailing_bits, so avoiding doing it seems better than relaxing the check inside the function.
[21:24:48 CET] <jamrial> alright
[21:28:24 CET] <agrecascino> can someone tell me how appalling my patch is
[21:28:45 CET] <jamrial> jkqxz: something like https://pastebin.com/raw/0jkfjMnu ?
[21:28:58 CET] <durandal_1707> agrecascino: link to the patch?
[21:29:15 CET] <agrecascino> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-February/239944.html
[21:29:26 CET] <agrecascino> nobody responded to my rfc asking how to do this better
[21:29:43 CET] <agrecascino> so i just did it to hopefully get people to yell at me how to do it right
[21:33:05 CET] <jkqxz> jamrial:  Yeah.
[21:35:47 CET] <durandal_1707> agrecascino: i have no idea, wait several days, ping it weekly and request somebody to push it if nobody replies
[21:36:18 CET] <JEEB> agrecascino: regarding teh counting - did the spec note that this should work?
[21:43:58 CET] <cone-829> ffmpeg 03James Almer 07master:3e8b8b6b509c: avcodec/cbs_av1: don't call cbs_av1_read_trailing_bits() when no bits remain in the OBU
[21:45:07 CET] <jamrial> jkqxz: done, thanks
[21:48:46 CET] <jamrial> jkqxz: there's also the issue of the parsing code for mastering display metadata checking for a range of values that don't really apply
[21:48:58 CET] <jamrial> they are not stored the same way as in hevc sei messages
[22:00:26 CET] <jkqxz> Hmm, right, yeah.  They use the whole range in the obvious way rather than a funny unit.
[22:18:14 CET] <kierank> ¬1350, wow that's not a cheap flight
[22:18:35 CET] <durandal_1707> not economy class
[22:28:24 CET] <kierank> could be last minute
[22:45:46 CET] <agrecascino> JEEB, the spec says absolutely nothing?
[22:46:01 CET] <JEEB> wee
[22:46:28 CET] <agrecascino> idk it's been a little while but there was nothing in there that would help with implementation
[23:46:10 CET] <agrecascino> tbh someone is fixing the hang so
[23:46:19 CET] <agrecascino> who needs one more sidx :^)))))))))
[00:00:00 CET] --- Mon Feb 11 2019