[Ffmpeg-devel-irc] ffmpeg-devel.log.20191018

[burek]

[00:55:04 CEST] <jamrial> nevcairiel, BBB: i'm divided about reordered_opaque. we really shouldn't check its value, but unconditionally propagating it requires one allocation per packet even if you're not going to use it
[01:16:04 CEST] <jamrial> fuck it
[01:27:03 CEST] <Lynne> buffer pool
[01:29:53 CEST] <BBB> jamrial: hm...
[01:30:04 CEST] <BBB> jamrial: so the concern is just the overhead of the alloc per packet?
[01:30:10 CEST] <BBB> how do other codecs do it?
[01:30:19 CEST] <BBB> or do they not care b/c libaom is not threaded etc?
[01:30:24 CEST] <BBB> (frame-threaded
[01:34:34 CEST] <jamrial> BBB: other codecs use get_buffer and copy the value in ff_decode_frame_props()
[01:35:01 CEST] <jamrial> with libdav1d we're not using get_buffer, and the reordering is done in the external library
[01:39:02 CEST] <BBB> and passing reordered_opaque in an user_data field in the input packet is not possible?
[01:39:11 CEST] <BBB> or are you already using all of them? :-p
[01:42:48 CEST] <jamrial> i'm using all of them for their proper values, yes :p
[01:43:22 CEST] <jamrial> the only one remainin is the Dav1dUserData pointer
[01:43:27 CEST] <jamrial> which is what i'm using
[01:44:11 CEST] <Lynne> just use a buffer pool
[01:47:01 CEST] <jamrial> Lynne: not for an 8 byte value
[01:51:09 CEST] <Lynne> it doesn't really matter then, on linux such a small alloc will easily be cached, and its by far not the biggest problem on windows
[04:01:09 CEST] <cone-309> ffmpeg 03Jun Zhao 07master:85e2b222e910: lavfi/avf_showspectrum: add error handle if av_asprintf return null
[04:01:09 CEST] <cone-309> ffmpeg 03Jun Zhao 07master:ed3c317deac9: fftools/ffmpeg_opt: add error handle if av_asprintf return null
[04:01:09 CEST] <cone-309> ffmpeg 03Jun Zhao 07master:feaec3bc3133: lavf/hlsenc: fix memory leak
[10:35:45 CEST] <cone-290> ffmpeg 03Paul B Mahol 07master:daf2bef98ded: avfilter/af_acrossover: fix memory leak
[10:49:59 CEST] <cone-290> ffmpeg 03Paul B Mahol 07master:fddef964e8aa: avfilter/vf_colorspace: fix memmory leaks
[11:33:45 CEST] <JEEB> wow, I completely missed that track_ids can get set rather late in the game :)
[11:34:02 CEST] <cone-290> ffmpeg 03Paul B Mahol 07master:8e30514c4c19: avfilter/buffersink: cosmetics
[11:34:27 CEST] <JEEB> as in, with fragmented mp4 you can't expect track_ids to be around during at least the first fragment
[11:35:30 CEST] <JEEB> so if you're comparing two MOVTrack *s I guess it's just better to compare for equality :)
[11:35:38 CEST] <JEEB> that way it works in either case, before or after
[20:49:45 CEST] <thardin> anyone in here living in london and interested in an audio backend jerb?
[22:03:50 CEST] <cone-161> ffmpeg 03Paul B Mahol 07master:3b580f9dfe71: avfilter/vf_maskfun: fix memleak
[23:25:54 CEST] <cone-161> ffmpeg 03Paul B Mahol 07master:0528adbd85d6: avfilter/vf_shuffleplanes: add mising query_formats()
[00:00:00 CEST] --- Sat Oct 19 2019