[Ffmpeg-devel] [patch] Snow - add_yblock x86 asm

[Yartrebo]

On Sun, 2005-04-10 at 17:50 +0200, Aurelien Jacobs wrote:
> On Sun, 10 Apr 2005 00:58:46 -0400
> Yartrebo <yartrebo at earthlink.net> wrote:
> 
> > fixed, hopefully. I need someone with an AMD-64 machine to test it.
> 
> Ok, I tested that patch on AMD64.
> 
> But first I tested snow encoding with a fresh ffmpeg checkout.
> The result is that it simply crashes :-( (see the attached debug log)
> As the crash happened in an inline function, I tried to add a
> #define always_inline
> to ease the debugging. The result was no more crashes !! So I don't
> investigated further to find what causes this crash.
> So finally, with no inlines, I was able to do a snow encoding, but
> when playing the resulting file, every 12th frames, I get one solid
> grey frame ! (tested with several different input format)
> I have no idea what causes this.
> 
> So now, finally I tested this snow optimisation patch on AMD64.
> It compiles and run as well as the original snow (I mean, with
> always_inline disabled). So the patch seems to be amd64 compliant :-)
> 
> I haven't done any benchmark as the results would be meaningless since
> I disabled inlines.
> 
> If you want me to do more tests, just let me know.
> 
> Aurel
The every 12th frame business is most likely an issue with keyframe
decoding. Thank you very much for testing the code and sending the bug
report.

Robert