[Ffmpeg-devel] gcc 4x compilation issues on ppc

[Michael Niedermayer]

Hi

On Sunday 17 April 2005 17:17, Diego Biurrun wrote:
> On Sat, Apr 16, 2005 at 01:09:22PM +0200, Diego Biurrun wrote:
> > On Sat, Mar 19, 2005 at 11:06:02PM +0100, Michael Niedermayer wrote:
> > > On Saturday 19 March 2005 19:12, Bret Hughes wrote:
> > > > On Sat, 2005-03-19 at 06:25, James A. Morrison wrote:
> > > > > Bret Hughes <bhughes at elevating.com> writes:
> > > > > > vu32 has this definition:
> > > > > > #define vu32(v) ((vector unsigned int)(v))
> > > > > >
> > > > > > I can't tell what is happening here. mzero is defined as a float
> > > > > > so somehow these statements are assigning a float value to mzero.
> > > > > >  is this a cast and would casting the righthand side of the
> > > > > > assignment to a float be correct?
> > > > > >
> > > > > >   mzero = ((vector float)vec_splat_u32(-1));
> > > > > >   mzero = ((vector float)vec_sl(vu32(mzero), vu32(mzero)));
> > > > > >
> > > > > > got to be more happening.  If not I have made the changes and it
> > > > > > at least compiles now.
> > > > >
> > > > >  No, that is exactly what is happening.  Please try sending your
> > > > > patch.
> > > >
> > > > See attached patch.
> > >
> > > ok, can someone with ppc confirm that this still works? (same md5 when
> > > encoding something to mpeg, NOT regression tests)
> >
> > I'd love to test this, but I don't have the patch around anymore.  If
> > somebody could send it to me I'd love to give it a spin.  An example
> > command line for testing would also help.
>
> OK, tested on my 12" G4 PowerBook.
>
> Here are the command lines:
>
> ffmpeg -i xine_about.avi -r 25 xine_about_vanilla.mpg
> ffmpeg -i xine_about.avi -r 25 xine_about_patch_applied.mpg
>
> Here are the results:
>
> 55891036ffd731fa98ddcd2b5be6b69f  xine_about_patch_applied.mpg
> 55891036ffd731fa98ddcd2b5be6b69f  xine_about_vanilla.mpg
>
> So I guess the patch is safe to apply.

ok, feel free to apply it

[...]
-- 
Michael

"nothing is evil in the beginning. Even Sauron was not so." -- Elrond