[Ffmpeg-devel] [PATCH] Add Dirac support to ffmpeg]

[Michael Niedermayer]

Hi

On Thu, Aug 25, 2005 at 05:00:31PM +0100, Andrew Kennedy wrote:
> 
> **Amended Dirac patch for ffmpeg
> **Tested with ffmpeg cvs (as of August 25, 2005 10:00am)
> **Author(s): Andrew Kennedy (dirac_dev at users.sourceforge.net) (main)
>              Anuradha Suraparaju (asuraparaju at users.sourceforge.net)
>              (minor mods)
> 
[...]

> +/* dirac codec */
> +#ifdef CONFIG_DIRAC
> +    register_avcodec(&dirac_decoder);
> +#ifdef CONFIG_ENCODERS
> +    register_avcodec(&dirac_encoder);
> +#endif
> +#endif

register_avcodec(*_decoder); should be under CONFIG_*_DECODER and
register_avcodec(*_encoder); should be under CONFIG_*_ENCODER

if they are not under these then --enable/disable-codec will not work
and ideally they should not be under any other #ifdef 


> +    /* input frame buffer */
> +    unsigned char *p_in_frame_buf;
> +    
> +    /** output frame buf */
> +    unsigned char* p_out_frame_buf;

mixing doxygen compatible comments with non doxy 


[...]

> +                /** tell ffmpeg about sequence details*/
> +                avccontext->height=p_dirac_params->p_decoder->seq_params.height;

AFIAK doxygen comments are not supposed to be put in the middle of functions
or does current doxygen do something with these?


> +        dirac_buffer (p_dirac_params->p_decoder, buf, buf+buf_size);
> +    while (1)
> +    {
> +         /** parse data and process result */
> +         DecoderState state = dirac_parse (p_dirac_params->p_decoder);
> +         switch (state)
> +         {
> +            case STATE_BUFFER:
> +                 return buf_size;
[...]
> +            default:
> +                break;
> +            }
> +        }

there is a lot of inconsistant indention in the files, often changing by
+-1, but these arent a problem as i will run the file through indent before
applying if you are too busy to fix them

[...]

-- 
Michael