[Ffmpeg-devel] [PATCH] from DivX, Part 9: bitstream crashes

[Michael Niedermayer]

Hi

On Fri, Dec 16, 2005 at 02:15:39PM -1000, Steve Lhomme wrote:
> Here is a list of patches that fixes errors when reading bitstreams.

> Index: libavcodec/dv.c
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/dv.c,v
> retrieving revision 1.65
> diff -u -r1.65 dv.c
> --- libavcodec/dv.c	2 Sep 2005 08:30:26 -0000	1.65
> +++ libavcodec/dv.c	17 Dec 2005 00:01:04 -0000
> @@ -343,7 +343,7 @@
>  	if (pos >= 64)
>  	    break;
>          
> -        assert(level);
> +//        assert(level);

level==0 is either a bug in the code or more likely a buggy bitstream (IMHO),
we should check for that ... make it optional if you want with some macro but
dont just remove it

[...]

-- 
Michael