[Ffmpeg-devel] [PATCH] x264 interface update

[Michael Niedermayer]

Hi

On Tue, Dec 20, 2005 at 08:50:36AM +0000, Robert Swain wrote:
> Hello,
> On 12/18/05, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Hi
> > On Sun, Dec 18, 2005 at 04:36:00AM -0000, Robert Swain wrote:
> > > Hello,
> 
> [...]
> 
> > > - Why do 'flags2' flags require an argument despite the argument not
> > > appearing to have a function? (I tried -brdo 0 and -brdo 1, and both enabled
> > > brdo)
> >
> > because the option parser isnt perfect, send patch, furthermore flags1 need an
> > argument too currently unless they havnt been ported to the new system
> 
> What do you mean about flags1 being ported?

there was the old system for setting stuff in AVCodecContext and the new
through AVOption ...


> 
> > [...]
> 
> > > - Why does setting a float in the default value parameter of the
> > > libavcodec/utils.c options array not actually set the default value to that
> > > value?
> > > I used GDB to print the value of avctx->ratetol for example. In the value in
> > > options[] (libavcodec/utils.c) was 1, but in AVCodecContext it was 0. Should
> > > avcodec_get_context_defaults() be used for setting default values?
> >
> > avcodec_get_context_defaults() could _maybe_ be changed to extract and set all
> > the defaults for AVCodecContext (patch welcome assuming this has no sideeffects)
> 
> I wasn't suggesting that this be done. I just meant to enquire as to
> whether putting s->ratetol = 1.0; in avcodec_get_context_defaults()
> would produce the correct default value. I did some further testing
> and in fact the default values in options[] are completely ignored.
> Why are they there? Legacy? A hint at the default? Not updated to use
> them yet?

the default values in options[] should be used but arent yet, you can either
set defaults in options[] and avcodec_get_context_defaults() or change the
later to extract them from options[]


[...]

-- 
Michael