[Ffmpeg-devel] [PATCH] from DivX, Part 1: cosmectic changes

The Wanderer inverseparadox
Thu Dec 22 18:12:11 CET 2005


On 12/22/2005 09:34 AM, Diego Biurrun wrote:

> On Thu, Dec 22, 2005 at 09:14:35AM +0100, Guillaume POIRIER wrote:
> 
>> On 12/22/05, Diego Biurrun <diego at biurrun.de> wrote:
>> 
>> 
>>> OK, I've replaced all tabs with spaces along with some
>>> prettyprinting on the code where it was necessary after the tab
>>> removal, in related places and a few random places along the way.
>> 
>> How did you do it? Has it been pretty much been like running:
>> expand | sed 's/ *$//' over the files, and removing all trailing
>> spaces?
> 
> I just repeated
> 
>   find . -exec sed -i -e 's/ *$//' -e 's/	*$//' {} \;
> 
> a few times to remove all trailing whitespace.

Hmm. How does that fail to remove whitespace on lines which consist only
of whitespace? I do not consider those to be "trailing whitespace"; they
exist for convenience of indentation, and I'd be bothered by trying to
work with code which did not have them there. (Then again, I don't work
with this code, so my opinion may not be relevant.)

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.





More information about the ffmpeg-devel mailing list