[Ffmpeg-devel] Bug (?) in mpeg12.c: find_frame_rate_index

[Mean]

Rich Felker wrote:

>On Sat, Jul 23, 2005 at 12:25:53PM +0000, Mean wrote:
>  
>
>>Hello,
>>      If we assume x/y is the num/den of the incoming stream
>>   and a/b is the num/den of the mpeg rate table
>>  
>>      The formula in find_frame_rate_index tries to minimize
>>
>>      1001/b*a*x-1001*y
>>
>>      whereas it should try to minimize
>>
>>      1001/b*a*y-1001*x
>>
>>   (i.e. time_base.num/den seems inverted)
>>    
>>
>
>No, time base is not a framerate but a unit of time. e.g. for 25fps
>content you would use a time base of 1/25 second.
>
>  
>
    Ah, ok.
    Thanks for the explanation.