[Ffmpeg-devel] [PATCH]video codec nine bitstream fixes

[Alexander Strasser]

Hi,

Ivan Kalvachev wrote:
> I had spend some time comparing specifications to the existing code,
> and found few mistakes in the sequence reader.
> I also made few more checks, made some warning critical etc..
> 
> Please review them before I commit.

  Just had a quick look and I also doubt i could verify much when
having a longer one, there is one non-critical thing that caught
my attention.


> Index: vc9.c
> ===================================================================
[...]
>  #if HAS_ADVANCED_PROFILE
>      if (v->profile == PROFILE_ADVANCED)
>      {
>          v->level = get_bits(gb, 3);
> +	if(v->level >= 9)
> +	{
> +	    av_log(avctx, AV_LOG_ERROR, "Reserved LEVEL %i\n");
> +	}

  Didn't you miss v->level in that av_log call?
Also indentation is a bit messed up, would be nice if you would
correct it in case you commit as correcting it afterwards is
troublesome.

  Alex (beastd)