[Ffmpeg-devel] [PATCH]video codec nine bitstream fixes

[Alexander Strasser]

Hi Michael,

Michael Niedermayer wrote:
> On Sunday 08 May 2005 18:28, Alexander Strasser wrote:
> [...]
> > >  #if HAS_ADVANCED_PROFILE
> > >      if (v->profile == PROFILE_ADVANCED)
> > >      {
> > >          v->level = get_bits(gb, 3);
> > > +	if(v->level >= 9)
> > > +	{
> > > +	    av_log(avctx, AV_LOG_ERROR, "Reserved LEVEL %i\n");
> > > +	}
> >
> >   Didn't you miss v->level in that av_log call?
> 
> not to mention that checking 3 bits >= 9 is a little silly

  Right. Also this makes me guess there is some other underlying
issue, because if there really is something reserved like 9 or
higher how will it work in future when we are reading 3 bits here.
Or the 9 is just a typo, or the check doesn't belong there at all
and the code was just correct before.
  I must add that I don't know anything about VC9.

  Alex (beastd)