[Ffmpeg-devel] segfault in ff_mpeg1_find_frame_end()

[Stefan Lucke]

On Sonntag, 10. April 2005 21:38, Stefan Lucke wrote:
> On Sonntag, 10. April 2005 20:37, M?ns Rullg?rd wrote:
> > Stefan Lucke <stefan at lucke.in-berlin.de> writes:
> > 
> > > Hi,
> > >
> > > We are developing a plugin for vdr named softdevice. Plugins homepage
> > > is at http://softdevice.berlios.de .
> > >
> > > I get a segfault in function mentioned in subject. The segfault happens
> > > when there is a transition in aspect ratio from 16:9 to 4:3. It happens not
> > > when the stream is played the first time but when its played the 3rd time.
> > > But this may vary (segfault may happen at the first time too).
> > 
> > That makes me suspect a problem in your code.  Could you be
> > accidentally using a freed buffer?  Maybe a race between threads.
> 
> That was one of my initial thoughts too. But I think it is related to the thread:
> "bug in aspect ratio change detection" from 2005-04-02.  For
> a test, I backed out Ivan Kalvachev's change (mpeg12.c from
> rev 1.227 to 1.228). So I got no segfaults any more, but aspect ratio
> change is not detected correct. Then I used my rejected patch and
> so I've no segfaults and aspect ratio is detected correct ;-) .
> 

Now I think it could be fixed in softdevice. At least when replacing
av_read_packet() by av_read_frame() it doesn't crash anymore.

-- 
Stefan Lucke