[Ffmpeg-devel] [PATCH] different vorbis extradata handling
Måns Rullgård
mru
Fri May 13 22:38:31 CEST 2005
Nico Sabbi <nsabbi at tiscali.it> writes:
> M?ns Rullg?rd wrote:
>
>>>
>>>here's the fallback patch.
>>>Successfully testes on all avi samples, but I could never generate
>>>working nut samples: everytime
>>>ffmpeg crashes with FPEs.
>>>
>>>Ok to commit?
>>
>>I'd much rather do it by checking the first two bytes. It should be
>>perfectly fail-safe.
>
> but too bond to the current implementation of the headers; imo in the
> future it may fail
Actually, it can't. With the old format the first byte must be zero,
but with the new format it can never be zero.
--
M?ns Rullg?rd
mru at inprovide.com
More information about the ffmpeg-devel
mailing list