[Ffmpeg-devel] ReplayGain for Vorbis decoder

[Måns Rullgård]

castet.matthieu at free.fr writes:

> Selon Milan Cutka <milan_cutka at yahoo.com>:
>
>> I'm adding VorbisGain tag support to Vorbis decoder. It requires
>> parsing of comments header which I implemented already. Right now
>> I'm deciding whether to directly multiply decoded samples in
>> vorbis_decode_frame or add new field to AVCodecContext, fill it
>> with found multiplier and let the application to perform the
>> multiplication. I'd like to know your opinions. Thanks.
>>
> Well it is quite ugly to pass option to vorbis decoder via comment which are
> normaly decoded in ogg demuxer...

I agree.  A better idea might be to have the demuxer fill in some
field in an appropriate place, and let the application deal with it.
ID3v2 tags can have similar things in them, if we'll ever support
those.

> Who invented that ?

It's a little on the far side even for Xiph.

-- 
M?ns Rullg?rd
mru at inprovide.com