[Ffmpeg-devel] [PATCH] Missing "inttypes.h" on windows

[Michel Bardiaux]

Steve Lhomme wrote:
> Michel Bardiaux wrote:
> 
>> Diego Biurrun wrote:
>>
>>> On Sun, Nov 06, 2005 at 11:25:18PM -0800, Steve Lhomme wrote:
>>>
>>>> This is the kind of trick we added to our source base :
>>>>
>>>> #ifdef _MSC_VER
>>>> #    define EMULATE_INTTYPES
>>>> #    define strcasecmp stricmp
>>>> #endif
>>>
>>>
>>>
>>>
>>> What is this _MSC_VER #define?  
>>
>>
>>
>> It will evaluate to TRUE when compiling with any MS compiler.
> 
> 
> Yes, that's what you need to test to know if the compiler comes from 
> MSVC. There are different values depending on the versions.
> 
>>> And why do you #define strcasecmp?
>>
>>
>>
>> It is indeed not needed, because it is already in 
>> libavformat/os_support.h. However, that file should go in libavutil, 
>> and strcasecmp should be aliased to stricmp for Win32, not just for OS2.
> 
> 
> Given all the stuff from inttypes.h is used in libavcodec, I don't think 
> any file in libavformat/ is the correct location to fix this.
> 

That's what I meant: this stuff should go in libavutil.

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/