[Ffmpeg-devel] [RFC] More PCM formats (was: [PATCH] demuxer for dcinema audio)

[Michael Niedermayer]

Hi

On Thu, Sep 01, 2005 at 07:13:58PM +0200, Reimar D?ffinger wrote:
> Hi,
> On Wed, Aug 31, 2005 at 12:55:32PM +0200, Reimar D?ffinger wrote:
> > Ok, I did a quick hack to show what I am thinking about. It is not
> > finished and will not yet work, but before spending more time on it I
> > want to get some comments.
> 
> No reply :-(. 

well, that was because i wasnt entirely happy with it as it converts
everything to 16bit in the decoder, we really should finish at least 32bit
integer and 32bit float audio support ...
but i dont see any disadvantage in it in principle (its better to support
these formats by convertng to 16bit then not to support them at all ...)


> Well, I finished it. If you have better suggestions for
> the names, please go ahead.
> Any other suggestions for improvement are welcome, too.

maybe use av_get_packet() it would make the code 1 or 2 lines shorter


> The macros I introduced in pcm.c are just a suggestion too, especially

IMHO they should be changed to inline functions, as thats cleaner, unless
of course its slower, that brings us to the next point, it must be
benchmarked to ensure its not significantly slower


> since the one for encoding do not set the lower bits to 0 for the the 24
> and 32 bit formats.

uninitalized bytes are not acceptable, they could messup the regression
tests


[...]

-- 
Michael