[Ffmpeg-devel] Re: Darwin/OSX dylib Support

[Lina Pezzella]

> On Fri, Sep 02, 2005 at 12:39:18AM -0400, Lina Pezzella wrote:
>
>>
>> The attached patch for Darwin/OSX dylib support was made against the
>> current CVS (as of about 7PM EST tonight) and addresses the below
>> issues. Hopefully you'll see this patch as being a bit cleaner.
>>
>>
>>> IMHO version info does not belong in a makefile
>>>
>>
>> Fixed in the attached patch.
>>
>
> Still present in the patch I looked at ...
>

I moved the version information into Configure rather than putting it  
in each Makefile. I don't know of any other place to put the version  
information as it's needed by the Darwin linker. If this is still  
unacceptable, please let me know where you would like the version  
information. As a note here, I've removed version information from  
the libpostproc makefile in my patch that was previously there, so  
obviously someone didn't think it was a problem at one point.

>
>>> rejected, change the various variables or add a new one if needed  
>>> but
>>> adding a ifeq to every line of every makefile for every system is
>>> not acceptable
>>>
>>
>> Fixed for all cases where this was possible with my knowledge.
>>
>>
>>> fix the include paths instead
>>>
>>
>> Done.
>>
>
> Still present in the patch I looked at ...
>

I fixed the include path. If you are referring to the ifeq lines,  
those are fixed in all cases where it was possible. There is an ifeq  
in configure for Darwin, but that's one place and there are others  
for other systems there as well, so I don't see the problem. As an  
added note, you have separate ifeq's for windows...

--Lina Pezzella
Ebuild & Porting Co-Lead
Gentoo for OS X