[Ffmpeg-devel] [PATCH] CONFIG_MUXERS

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Wed, Sep 21, 2005 at 11:28:45PM +0200, Michael Niedermayer wrote:
>> 
>> On Wed, Sep 21, 2005 at 11:09:49PM +0200, Diego Biurrun wrote:
>> > On Wed, Sep 21, 2005 at 04:03:21PM +0200, Michael Niedermayer wrote:
>> > > 
>> > > On Wed, Sep 21, 2005 at 11:04:23AM +0200, Diego Biurrun wrote:
>> > > > 
>> > > > OK, here is a patch that fixes --disable-encoders and
>> > > > --disable-decoders in configure.  It compiles fine after my
>> > > > commit for the misplaced #ifdef
>> > > > 
>> > > > [...]
>> > > > 
>> > > > OK to apply the patch anyway or does this have to be fixed before?
>> > > 
>> > > no, CONFIG_EN/DECODERS should be set depending upon if there are any 
>> > > *CODERS enabled, not by --disable-en/decoders
>> > 
>> > Umm, right now it is set unconditionally, my patch fixes that.
>> > 
>> > What are the semantics you are looking for?  Shouldn't
>> > --disable-encoders disable all individual encoders and not define
>> > CONFIG_ENCODERS?
>> 
>> yes, but if you disable all codecs individually CONFIG_ENCODERS should
>> not be set either,
>
> That seems rather pointless to me since there is such an easy way to
> disable all encoders in one go (--disable-encoders)...

IMHO, it shouldn't matter how the encoders got disabled.  The end
result of the compilation should still be the same.

>> this could be extended to othr things like DCT_ENCODERS
>> MOTION_COMPENSATING_ENCODER and so on and this then could be used to
>> disable various common parts of libav*
>
> You mean that --disable-encoders should disable DCT_ENCODERS, etc as
> well?

I'd rather say that any encoder using dct being enabled should
automatically enable DCT_ENCODERS.  Logically, it's equivalent, of
course.

-- 
M?ns Rullg?rd
mru at inprovide.com