[Ffmpeg-devel] [PATCH] fix for PSP encoding

[Guillaume POIRIER]

Hi,

On 9/22/05, oandrieu at gmail.com <oandrieu at gmail.com> wrote:
>  Michael Niedermayer [Wednesday 21 September 2005] :
>  >
>  > Hi
>  >
>  > On Tue, Sep 20, 2005 at 12:38:56AM +0200, oandrieu at gmail.com wrote:
>  > Content-Description: message body and .signature
>  > >  Michael Niedermayer [Monday 19 September 2005] :
>  > >  >
>  > >  > Hi
>  > >  >
>  > >  > On Fri, Sep 16, 2005 at 02:33:17AM +0200, oandrieu at gmail.com wrote:
>  > >  > > Hi,
>  > >  > >
>  > >  > > The psp format in ffmpeg apparently broke with the latest firmware of
>  > >  > > the PSP (2.0). Here's a patch.
>  > >  > >
>  > >  > > It's basically the same patch that was posted on the list a
>  > >  > > couple of months ago. Some parts were not committed because of
>  > >  > > issues with the widechar conversion function used to encode the
>  > >  > > title of the stream: here I just handle the case where the title
>  > >  > > is in ASCII (any character with a high bit is replaced by a
>  > >  > > '?'). It's a bit crude, but heh.
>  > >  > >
>  > >  > > --
>  > >  > >    Olivier
>  >
>  > > -#define MODE_PSP 3 // example working PSP command line:
>  > > +#define MODE_PSP 3
>  > > +// example working PSP command line:
>  > [...]
>  > > -    put_tag(pb, "APRF");   /* audio */
>  > > +    put_tag(pb, "APRF");  /* audio */
>  > [...]
>  > > -    put_be32(pb, 0x34 );  /* size */
>  > > +    put_be32(pb, 0x34 );   /* size */
>  >
>  > cosmetics
>
> Yes. And ?

Nuke them, all of them! It makes the reviewing process more time-consuming.

Guillaume
--
Reading doesn't hurt, really!
  -- Dominik 'Rathann' Mierzejewski