[Ffmpeg-devel] [PATCH] introduce swscale interface inlibavcodec

[Michael Niedermayer]

Hi

On Wed, Apr 05, 2006 at 09:53:14AM +0200, Luca Abeni wrote:
> Hi,
> 
> On Tue, 2006-04-04 at 12:38 +0200, Luca Abeni wrote:
> > [...] 
> > > > When I wrote that part of the code, this seemed to be a smart idea :)
> > > > But I am ready to remove this stuff if it is not acceptable.
> > > 
> > > remove it IMHO, sws should always use the functions passed into
> > > sws_global_init()
> > Ok, I'll send an updated libswscale.diff patch in a short time.
> Here it is

[...]

> @@ -1494,8 +1495,8 @@ static int rgb2rgbWrapper(SwsContext *c,
>  		case 0x83: conv= rgb15to32; break;
>  		case 0x84: conv= rgb16to32; break;
>  		case 0x86: conv= rgb24to32; break;
> -		default: MSG_ERR("swScaler: internal error %s -> %s converter\n", 
> -				 vo_format_name(srcFormat), vo_format_name(dstFormat)); break;
> +		default: MSG_ERR("swScaler: internal error %d -> %d converter\n", 
> +				 srcFormat, dstFormat); break;

ideally we should use avcodec_get_pix_fmt_name here but that would add a
dependany to lavc ...

maybe duplicating the pix_fmt names table in the binary (use #include
somehow to avoid duplication in the source) would be a solution?

anyway IMHO leave a function which turns pix_fmt into a string even if it 
just puts the integer value into it

anyway, except that patch looks ok ...

[...]

-- 
Michael

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is