[Ffmpeg-devel] MPEG2 seeking broken

[Steve Lhomme]

On Thu, 2006-04-20 at 11:28 +0200, Michael Niedermayer wrote:
> Hi
> 
> On Thu, Apr 20, 2006 at 08:12:27AM +0200, Steve Lhomme wrote:
> [...]
> > >the code submitted is nothing else as
> > >
> > >if(ref_picture == NULL){
> > >#ifdef DEBUG
> > >    abort();
> > >#endif
> > >    ...
> > >}
> > 
> > I guess it's up to the MPEG2 maintainer to fix that bug the FFMPEG way then.
> 
> first you post a bugreport related to your code which is not reproducable
> in ffmpeg and ffplay

http://article.gmane.org/gmane.comp.video.ffmpeg.devel/29795

All the rest of the email is based on the false assumption that I never
submitted a bug report and here is the proof I did. Your memory is very
selective.

> next you post a fix to your bug by checking if the reference picture is
> mising in the innermost loop, which obviously is rejected with:
> "patch rejected, checking if the ref frame is NULL in the MB loop is
> not acceptable, check outside and allocate it or disacard the frame"
> 
> after that theres your first try to convince me to fix your bug:
> "Given you're the maintainer of the code I assume you can come up with a
> better patch for that. I have no idea what this thing is about. I just
> know it's not good to access NULL pointers and that this fixes the bug.
> I will keep my patch in DrFFMPEG until a 'better' fix comes here."
> 
> after that you post the patch we just disscussed above, which also
> simply uses the current picture instead of correctly allocating it
> like i suggested
> 
> i choose to ignore you as you ignored my comment to your first patch
> 
> Guillaume pings and i quickly review the patch and explain tersly why 
> its not ok
> 
> and finally you try again for the 2nd time to push your bug toward
> me with "I guess it's up to the MPEG2 maintainer to fix that bug the 
> FFMPEG way then."
> 
> so my final comment to you:
> if its reproduceable in ffmpeg/ffplay provide enough details for us
> to reproduce it, if you want a patch applied deal with all comments
> made, if you dont understand something just ask
> if you just want to fight your little fight against the ffmpeg project
> by submiting trash (assert+if, random repeatly rejected msvc workarounds,
> ...) then i can ban you off the list if you want after all this is not
> the first time you try something like this (MSVC workarounds, matroska
> patch, ...)
> and in case of the matroska patch, iam sure you remember, you
> 1. refused to provide a file so i could reproduce the bug
> 2. posted a unacceptable patch i rejected
> 3. expected me to fix your trash, which i even did
> 4. attacked me that i didnt test my code (remember you didnt
>    provide a sample for testing in the first place)
> 
> [...]