[Ffmpeg-devel] [PATCH] win32 can also exit properly

[Steve Lhomme]

Rich Felker wrote:
> On Mon, Apr 24, 2006 at 01:46:55AM +0200, Diego Biurrun wrote:
>> On Thu, Mar 23, 2006 at 10:48:37AM +0100, Steve Lhomme wrote:
>>> Steve Lhomme wrote:
>>>> ...when you press the 'q' key. It works win MinGW (and MSVC).
>>> What happened to that patch ?
>> Has anybody had a look at this?  It compiles fine for me on Linux and I
>> can still interrupt ffmpeg with the q key...
> 
> It looks wrong to me. WTF is kbhit? Where is it defined?
> 
> Looking again I see "conio.h"....ARRRG!!
> Steve will you stop sending patches that add disgusting windows-isms
> without even pointing them out?? Someone could have actually committed
> this crap...

Given the current code already makes an exception for windows I don't 
see much difference. But I understand making FFMPEG behave in an ugly 
way on Windows is probably the goal.

Now does this patch compile on your (non windows) machine ? And if so, 
do you see any other problem ?

Steve

-- 
robUx4 on blog <http://robux4.blogspot.com/>