[Ffmpeg-devel] [Patch] snowdsp_mmx.c to avoid or restore ebx

Martin von Gagern Martin.vGagern
Wed Aug 2 22:54:04 CEST 2006


Hello.

http://bugs.gentoo.org/show_bug.cgi?id=142380#c23

Since there is so much activity on the Gentoo bug about this, I tried to
get this fixed. Don't know too much about video editing or inline
assembly, but I think this might work.

I tried to use another register instead of ebx whenever possible. In
cases where all 6 general purpose and index registers are used, I
allocated a local variable and stored ebx there for the time being.
Using a local variable avoids worrying about changing esp and makes sure
all input arguments are still valid.

Maybe someone who knows what this piece of code is actually for could
give it a try if it still does what you'd expect it to do?

If the thing works in principle, I'm willing to investigate further how
to make my changes apply only if PIC is defined. With all those index
shifts it's gonna be messy, so I'd want to see if the principle works
before doing further work.

Note that I'm not a subscriber of this list, and right now only read
email that mentions me as to or cc.

Greetings,
 Martin von Gagern
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: snow_mmx.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060802/c8481704/attachment.txt>



More information about the ffmpeg-devel mailing list