[Ffmpeg-devel] [BUG] Vorbis artifacts

Michael Niedermayer michaelni
Thu Aug 31 15:43:38 CEST 2006


Hi

On Thu, Aug 31, 2006 at 03:02:22PM +0200, Luca Barbato wrote:
> Michael Niedermayer wrote:
> > On Thu, Aug 31, 2006 at 12:35:54PM +0200, Baptiste Coudurier wrote:
> >> Quick question, should we use DECLARE_ALIGNED(16) here or not ? 
> > 
> > yes it should be used
> > 
> 
> Should I duplicate it, just include a private header, move them to a
> public header (utils?)?

move to libavutil
it also might be a good idea to change DECLARE_ALIGNED_16() to 
DECLARE_ALIGNED(16 as thats somehow more flexible and simpler
and one thing which absolutely must be done is that DECLARE_ALIGNED_X
must provide exactly X alignment not some other random arch specific one

if some other arch specific alignment is needed then another macro could
be introduced DECLARE_ALIGNED_MAX for example which would then provide
the max needed alignment for the architecture

comments welcome ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list