[Ffmpeg-devel] [PATCH] mjpega bitfilter

[Michael Niedermayer]

Hi

On Fri, Dec 01, 2006 at 11:38:44AM +0100, Baptiste Coudurier wrote:
> Hi
> 
> $subject. Modify bitstream to allow mjpeg encoded files to be played by
> quicktime.

looks ok, but please commit the mjpeg.c and bytestream.h seperately, later
doesnt depent on the mjpeg.c stuff


[...]
> +            case DQT:  bytestream_put_be32(&poutbufp, i + 46); break; /* quant off */
> +            case DHT:  bytestream_put_be32(&poutbufp, i + 46); break; /* huff  off */
> +            case SOF0: bytestream_put_be32(&poutbufp, i + 46); break; /* image off */

why not?

case DQT: /* quant off */
case DHT: /* huff  off */
case SOF0:/* image off */
    bytestream_put_be32(&poutbufp, i + 46);
    break;

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is