[Ffmpeg-devel] [PATCH] Remove special install path for MinGW.

[angustia at arrozcru.no-ip.org]

Hello,

Quoting Diego Biurrun <diego at biurrun.de>:

> On Mon, Dec 04, 2006 at 10:57:38AM -0500, angustia at arrozcru.no-ip.org wrote:
>> Quoting Diego Biurrun <diego at biurrun.de>:
>>
>> >On Mon, Dec 04, 2006 at 11:21:35AM -0200, ramiro at lisha.ufsc.br wrote:
>> >>
>> >>I haven't seen any other library that does this install path
>> >>special-casing for Windows, and FFmpeg seems like it should be the last
>> >>program to support such a thing.
>> >
>> >This is due to the way MinGW cross-compilation is handled in configure.
>> >I've always been tempted to remove it.  In any case your patch is
>> >incorrect as --prefix will no longer work correctly.
>>
>> I don't understand how it will no longer work correctly. My rationale
>> was "let it be dealt with by default like it should be". Could you be
>> more specific as to how --prefix will no longer work correctly?
>
> The value of --prefix is checked before, so setting PREFIX later will
> hardcode it without allowing --prefix to override it.
>

I'm not setting PREFIX later. I'm just removing what used to be set  
later if !force_prefix.

*On linux* with --enable-mingw32 I get:
before the patch: install prefix   /FFmpeg
which is incorrect since there is no $PROGRAMFILES (the same as in  
Windows 98, which I've found out last week).
after the patch: install prefix   /usr/local

Without --enable-mingw32 I get on both cases:
install prefix   /usr/local

With --prefix=/somewhere I get on all cases:
install prefix   /somewhere

>> --- configure	(revision 7221)
>> +++ configure	(working copy)
>> @@ -1486,8 +1483,8 @@
>>  # Ugh, avisynth uses WINAPI calls. Generic tests won't work.
>>  if enabled avisynth; then
>>      save_flags
>> -    temp_extralibs -lvfw32
>> -    check_ld <<EOF && add_extralibs -lvfw32 || die "ERROR: vfw32 not found"
>> +    temp_extralibs -lavifil32
>> +    check_ld <<EOF && add_extralibs -lavifil32 || die "ERROR:   
>> avifil32 not found"
>
> Unrelated.
>
> Don't bother sending in a new patch with this hunk removed, though.  The
> idea of your patch is incorrect.

Sorry about the extra hunk. It was diff'd using the wrong tree. I  
believe the idea of my patch is correct, so new patch attached.

If it still is really incorrect and I failed miserably to see where I  
went wrong, I'll give up for now.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure_windows_path.patch
Type: text/x-patch
Size: 926 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061204/722146a2/attachment.bin>