[Ffmpeg-devel] [PATCH] Remove special install path for MinGW.

[Ramiro Polla]

Diego Biurrun wrote:
> On Mon, Dec 04, 2006 at 01:17:21PM -0500, angustia at arrozcru.no-ip.org wrote:
>   
>> Quoting Diego Biurrun <diego at biurrun.de>:
>>
>>     
>>> On Mon, Dec 04, 2006 at 10:57:38AM -0500, angustia at arrozcru.no-ip.org 
>>> wrote:
>>>       
>>>> Quoting Diego Biurrun <diego at biurrun.de>:
>>>>
>>>>         
>>>>> On Mon, Dec 04, 2006 at 11:21:35AM -0200, ramiro at lisha.ufsc.br wrote:
>>>>>           
>>>>>> I haven't seen any other library that does this install path
>>>>>> special-casing for Windows, and FFmpeg seems like it should be the last
>>>>>> program to support such a thing.
>>>>>>             
>>>>> This is due to the way MinGW cross-compilation is handled in configure.
>>>>> I've always been tempted to remove it.  In any case your patch is
>>>>> incorrect as --prefix will no longer work correctly.
>>>>>           
>>>> I don't understand how it will no longer work correctly. My rationale
>>>> was "let it be dealt with by default like it should be". Could you be
>>>> more specific as to how --prefix will no longer work correctly?
>>>>         
>>> The value of --prefix is checked before, so setting PREFIX later will
>>> hardcode it without allowing --prefix to override it.
>>>       
>> I'm not setting PREFIX later. I'm just removing what used to be set  
>> later if !force_prefix.
>>
>> *On linux* with --enable-mingw32 I get:
>> before the patch: install prefix   /FFmpeg
>> which is incorrect since there is no $PROGRAMFILES (the same as in  
>> Windows 98, which I've found out last week).
>> after the patch: install prefix   /usr/local
>>
>> Without --enable-mingw32 I get on both cases:
>> install prefix   /usr/local
>>
>> With --prefix=/somewhere I get on all cases:
>> install prefix   /somewhere
>>     
>
> What about MinGW?

Before patch:
./configure --enable-memalign-hack
install prefix   C:\Program Files (x86)/FFmpeg
./configure --enable-memalign-hack --prefix=/somewhere
install prefix   /somewhere

After patch:
./configure --enable-memalign-hack
install prefix   /usr/local
./configure --enable-memalign-hack --prefix=/somewhere
install prefix   /somewhere

> So what is a sensible default prefix for MinGW?
>   

My intention with this patch is that it shouldn't use any special prefix 
for MinGW. It should use the default like all other libs do. /usr/local 
is fine.

Ramiro Polla