[Ffmpeg-devel] I'm giving up

[Benjamin Larsson]

Baptiste Coudurier skrev:
> Benjamin Larsson wrote:
>   
>> Baptiste Coudurier skrev:
>>     
>>> Hi
>>>
>>> Michael Niedermayer wrote:
>>>  
>>>       
>>>> [...]
>>>>
>>>>    
>>>>         
>>>>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>>>>> index 96ea77a..4457969 100644
>>>>> --- a/libavcodec/avcodec.h
>>>>> +++ b/libavcodec/avcodec.h
>>>>> @@ -149,6 +149,7 @@ enum CodecID {
>>>>>      CODEC_ID_TIERTEXSEQVIDEO,
>>>>>      CODEC_ID_TIFF,
>>>>>      CODEC_ID_GIF,
>>>>> +    CODEC_ID_FFH264,
>>>>>       
>>>>>           
>>>> ok can be commited
>>>>
>>>>     
>>>>         
>>> Sorry but why is that needed ? Cannot an encoder be chosen based on his
>>> name ? Maybe Im missing something though.
>>>
>>>   
>>>       
>> If another id isn't added we can't use both x264 and the native encoder
>> in the same binary.
>>
>>     
>
> Ah, can this behaviour be changed easily ?
>   

I don't think it will be 2 lines of code for that.

> IMHO we should not add a new id, but disable native one if x264 is chosen
A configure option is easy to do though.


MvH
Benjamin Larsson