[Ffmpeg-devel] Re: help find compile problems

[Ronald S. Bultje]

Hi,

On Sun, 2006-12-10, Michael Niedermayer wrote:
> On Sun, Dec 10, 2006 at 10:20:04AM -0500, Ronald S. Bultje wrote:
> > Hi,
> > 
> > if ARCH_X86_{32,64} isn't defined (that was my own mistake, not a ffmpeg
> > bug), libavutil/common.h compiles ppc timer code on a x86, resulting in:
> > 
> > $ gcc -DHAVE_AV_CONFIG_H=1 -c -o vp3.o vp3.c -I../libavutil -I.. -Wall
> > /tmp/ccr54Ahb.s: Assembler messages:
> > /tmp/ccr54Ahb.s:13925: Error: no such instruction: `mftbu %ecx'
> > /tmp/ccr54Ahb.s:13926: Error: no such instruction: `mftb %eax'
> > /tmp/ccr54Ahb.s:13927: Error: no such instruction: `mftbu %edx'
> > /tmp/ccr54Ahb.s:13928: Warning: using `%dx' instead of `%edx' due to `w'
> > suffix
> > /tmp/ccr54Ahb.s:13928: Warning: using `%cx' instead of `%ecx' due to `w'
> > suffix
> > /tmp/ccr54Ahb.s:13929: Error: no such instruction: `bne 1b'
> > 
> > Attached patch will make it error out instead, by adding an extra check
> > for x86s before assuming ppc. This may not be wanted (normally people
> > shouldn't see it), but it makes such things easier to find if it does
> > occur. (Feel free to reject.)
> 
> yes, rejected :)
> 
> IMHO a ARCH_X86 define sanity check doesnt belong into the rdtsc code

Thinking about it, I guess configure is the right place to check for
this, and it sort of already does. As long as I run it. :-). So let's
just drop this. Sorry for the noise. (At least it's in the archives if
someone else sees it.)

Ronald