[Ffmpeg-devel] [PATCH] FLV decoder metadata reading

[Guillaume POIRIER]

Hi,

On 12/12/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Mon, Dec 11, 2006 at 03:39:06PM -0800, Allan Hsu wrote:

[..]

> > All fixed/changed in the attached version of the patch.
>
> patch looks ok

Patch compiles and seem to work alright, but regression tests are
broken (unrelated to this patch, they were broken before):

../ffmpeg_g -y -flags +bitexact -dct fastint -idct simple -y -strict
-2 -f pgmyuv -i vsynth1/%02d.pgm -an -vcodec snow -qscale 2 -flags
+qpel -me iter -dia_size 2 -cmp 12 -subcmp 12 -s 128x64
./data/a-snow.avi
FFmpeg version SVN-r7058, Copyright (c) 2000-2006 Fabrice Bellard, et al.
  configuration:  --enable-gpl --cpu=g5
  libavutil version: 49.1.0
  libavcodec version: 51.26.0
  libavformat version: 51.6.0
  built on Dec 12 2006 08:40:51, gcc: 4.0.1 (Apple Computer, Inc. build 5363)
pass:0 changed:9
pass:1 changed:7
pass:2 changed:2
pass:3 changed:0
pass:0 changed:7
pass:1 changed:5
pass:2 changed:1
pass:3 changed:0
pass:0 changed:15
pass:1 changed:6
pass:2 changed:0
pass:0 changed:14
pass:1 changed:5
pass:2 changed:1
pass:3 changed:0
pass:0 changed:17
pass:1 changed:5
pass:2 changed:0
pass:0 changed:18
pass:1 changed:8
pass:2 changed:1
pass:3 changed:0
pass:0 changed:22
pass:1 changed:6
pass:2 changed:0
pass:0 changed:17
pass:1 changed:9
pass:2 changed:1
pass:3 changed:0
pass:0 changed:7
pass:1 changed:4
pass:2 changed:2
pass:3 changed:0
pass:0 changed:11
pass:1 changed:2
pass:2 changed:0
pass:1 changed:4
pass:2 changed:0
pass:0 changed:24
pass:1 changed:11
pass:2 changed:9
pass:3 changed:3
pass:4 changed:0
pass:0 changed:8
pass:1 changed:1
pass:2 changed:0
pass:0 changed:6
pass:1 changed:4
pass:2 changed:6
pass:3 changed:1
pass:4 changed:0
pass:0 changed:12
pass:1 changed:4
pass:2 changed:0
pass:0 changed:10
pass:1 changed:3
pass:2 changed:1
pass:3 changed:0
pass:0 changed:19
pass:1 changed:8
pass:2 changed:5
pass:3 changed:2
pass:4 changed:2
pass:5 changed:0
pass:0 changed:18
pass:1 changed:4
pass:2 changed:0
pass:0 changed:8
pass:1 changed:4
pass:2 changed:4
pass:3 changed:1
pass:4 changed:0
pass:1 changed:10
pass:2 changed:1
pass:3 changed:2
pass:4 changed:2
pass:5 changed:0
pass:0 changed:14
pass:1 changed:3
pass:2 changed:1
pass:3 changed:0
pass:0 changed:13
pass:1 changed:3
pass:2 changed:0
pass:0 changed:10
pass:1 changed:2
pass:2 changed:1
pass:3 changed:0
pass:0 changed:6
pass:1 changed:4
pass:2 changed:1
pass:3 changed:0
pass:0 changed:11
pass:1 changed:1
pass:2 changed:0
pass:0 changed:9
pass:1 changed:4
pass:2 changed:1
pass:3 changed:0
pass:0 changed:12
pass:1 changed:5
pass:2 changed:3
pass:3 changed:2
pass:4 changed:0
pass:0 changed:14
pass:1 changed:4
pass:2 changed:1
pass:3 changed:0
pass:0 changed:18
pass:1 changed:5
pass:2 changed:1
pass:3 changed:0
pass:0 changed:18
pass:1 changed:5
pass:2 changed:2
pass:3 changed:0
pass:1 changed:9
pass:2 changed:4
pass:3 changed:0
pass:0 changed:13
pass:1 changed:3
pass:2 changed:2
pass:3 changed:0
pass:0 changed:12
pass:1 changed:5
pass:2 changed:2
pass:3 changed:0
pass:0 changed:28
pass:1 changed:4
pass:2 changed:4
pass:3 changed:0
pass:0 changed:14
pass:1 changed:9
pass:2 changed:3
pass:3 changed:5
pass:4 changed:0
pass:0 changed:8
pass:1 changed:5
pass:2 changed:1
pass:3 changed:0
pass:0 changed:11
pass:1 changed:4
pass:2 changed:1
pass:3 changed:0
pass:0 changed:13
pass:1 changed:1
pass:2 changed:0
pass:0 changed:11
pass:1 changed:6
pass:2 changed:4
pass:3 changed:1
pass:4 changed:1
pass:5 changed:0
pass:1 changed:4
pass:2 changed:3
pass:3 changed:0
pass:0 changed:21
pass:1 changed:10
pass:2 changed:3
pass:3 changed:1
pass:4 changed:0
pass:0 changed:14
pass:1 changed:7
pass:2 changed:0
pass:0 changed:22
pass:1 changed:7
pass:2 changed:2
pass:3 changed:0
pass:0 changed:14
pass:1 changed:4
pass:2 changed:1
pass:3 changed:1
pass:4 changed:0
pass:0 changed:11
pass:1 changed:2
pass:2 changed:1
pass:3 changed:0
../ffmpeg_g -y -flags +bitexact -dct fastint -idct simple -y -i
./data/a-snow.avi -f rawvideo -s 352x288 ./data/out.yuv
/Users/guillaumepoirier/Prgm/ffmpeg/tests/regression.sh: line 514:
5766 Bus error               $ffmpeg $FFMPEG_OPTS -benchmark $*
>$datadir/bench.tmp 2>/tmp/ffmpeg$$
make[1]: *** [codectest] Error 138
make: *** [test] Error 2

Platform is PPC/OSX, untested on x86

I'm reluctant to apply anything while the regtests are broken, so
patch NO applied yet.

Guillaume
-- 
An association of men who will not quarrel with one another is a thing
which has never yet existed, from the greatest confederacy of nations
down to a town meeting or a vestry.
 -- Thomas Jefferson
(when interviewed about MPlayer ML flamewars)
http://www.brainyquote.com/quotes/quotes/t/thomasjeff157207.html