[Ffmpeg-devel] [PATCH] flv muxer metadata

[Panagiotis Issaris]

Hi Allan,

On Mon, Dec 11, 2006 at 04:14:25PM -0800, Allan Hsu wrote:
> On Dec 11, 2006, at 2:15 PM, Michael Niedermayer wrote:
> [...]
> >>+const CodecTag flv_video_codec_ids[] = {
> >>+    {CODEC_ID_FLV1,    FLV_CODECID_H263  },
> >>+    {CODEC_ID_FLASHSV, FLV_CODECID_SCREEN},
> >>+    {CODEC_ID_VP6F,    FLV_CODECID_VP6   },
> >>+    {CODEC_ID_NONE,    0}
> >>+};
> >>+
> >>+const CodecTag flv_audio_codec_ids[] = {
> >
> >these 2 should either be static or have a ff_ prefix
> >
> >except that iam fine with the patch
> [...]
> 
> Here's the same patch, but with those two tables made static.
I just tried your patch, but it makes the regression tests fail. I think you've
forgotten to update the regression tests checksums.

With friendly regards,
Takis