[Ffmpeg-devel] [PATCH] asf-enc brokes packets with padding

[Michael Niedermayer]

Hi

On Wed, Dec 20, 2006 at 06:47:41PM +0200, Nikolay Dobrev wrote:
> Ok, sorry for that.
> I will send my last patch, wich is like the first one I sent. In the first
> one I stupidly forgot to change the argument of put_payload_parsing_info().
> I do not know if this is the right way to fix the problem. I think this is
> the way. If not, I beg someone else to do this.
> 
> On 12/20/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> >Hi
> >
> >tabs are forbidden in svn
> >{} placement is not matching the rest of asf-enc.c
> >and the code is duplicated from put_payload_parsing_info()

[...]


> @@ -569,9 +569,15 @@
>      put_byte(pb, ASF_PPI_PROPERTY_FLAGS);
>  
>      if (iLengthTypeFlags & ASF_PPI_FLAG_PADDING_LENGTH_FIELD_IS_WORD)
> -        put_le16(pb, padsize - 2);
> +    {
> +        put_le16(pb, *padsize - 2);
> +	*padsize -= 2;
> +    }
>      if (iLengthTypeFlags & ASF_PPI_FLAG_PADDING_LENGTH_FIELD_IS_BYTE)
> -        put_byte(pb, padsize - 1);
> +    {
> +        put_byte(pb, *padsize - 1);
> +	*padsize -= 1;
> +    }

this code still contains tabs
the {} still are placed on their own lines, missmaching the rest of the file
and the -1 / -2 are duplicated

and dont top post! (see google / wikipedia about top post)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire