[Ffmpeg-devel] [PATCH] Dll information for mingw32 builds

[Ramiro Polla]

M?ns Rullg?rd wrote:
>> @@ -1801,10 +1808,11 @@
>>  fi
>>  echo ".align is power-of-two" $asmalign_pot
>>  if test "$gpl" = "no" ; then
>> -    echo "License: LGPL"
>> +    license="LGPL"
>>  else
>> -    echo "License: GPL"
>> +    license="GPL"
>>  fi
>> +echo "License: $license"
>>  
>>  echo "Creating config.mak and config.h..."
>>  
>>     
>
> Unrelated.
>   
I use this new $licence variable to create correct license information 
in dllinfo.rc. I could make this a separate patch if preferable.
>> @@ -1946,6 +1954,8 @@
>>    echo "SLIBNAME_WITH_VERSION=${SLIBNAME_WITH_VERSION}" >> config.mak
>>    echo "SLIBNAME_WITH_MAJOR=${SLIBNAME_WITH_MAJOR}" >> config.mak
>>    echo "SLIB_EXTRA_CMD=${SLIB_EXTRA_CMD}" >> config.mak
>> +  echo "SLIB_EXTRA_OBJS=${SLIB_EXTRA_OBJS}" >> config.mak
>> +  echo "SLIB_EXTRA_DEP=${SLIB_EXTRA_DEP}" >> config.mak
>>    echo "SLIB_INSTALL_EXTRA_CMD=${SLIB_INSTALL_EXTRA_CMD}" >> config.mak
>>  fi
>>  echo "LIB_INSTALL_EXTRA_CMD=${LIB_INSTALL_EXTRA_CMD}" >> config.mak
>> @@ -2051,6 +2061,60 @@
>>      done
>>  fi
>>  
>> +# create dllinfo.rc files
>> +if test "$dllinfo" = "yes"; then
>> +    dllinfo_generate(){
>>     
>
> IMHO defining this function outside the if..fi block would look cleaner.
>
>   
Will change on next patch.
>> +    name=$1
>> +    comment=$2
>> +    version=$3
>> +    major=${version%%.*}
>> +    version_commas=`echo $version | sed s/\\\\./,/g`,0
>>     
>
> Replace that sed with "tr . ,".
>   
This too.
>   
>> +            VALUE "CompanyName",      "\000"
>> +            VALUE "FileDescription",  "$comment\000"
>> +            VALUE "FileVersion",      "$version\000"
>> +            VALUE "InternalName",     "$name\000"
>>     
>
> Is windows really so braindead that it requires an extra null
> character at the end of those strings?  Not that I'm surprised or
> anything...
>
>   
I had based myself on Mplayer's mplayer.rc file: 
http://svn.mplayerhq.hu/mplayer/trunk/osdep/mplayer.rc?view=markup
Nothing bad happens if I remove them, so I believe it's fine to remove them.
>> -lib:
>> +lib: $(SLIB_EXTRA_DEP)
>>     
>
> This is wrong.
>   
Each dllinfo.rc depends on version.h created on the build folder to 
include the correct FFmpeg version number.
> BTW, what is this stuff good for?
>
>   

Provide information about the dlls, like when you look at the file's 
properties, as can be seen here: 
http://arrozcru.no-ip.org/ffmpeg_patches/avutil.dll.png


Ramiro Polla