[Ffmpeg-devel] [PATCH] disable w32threads when pthreads are enabled

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Sat, Dec 23, 2006 at 11:31:38PM -0500, angustia at arrozcru.no-ip.org wrote:
>> Quoting Diego Biurrun <diego at biurrun.de>:
>> 
>> >On Sun, Dec 24, 2006 at 12:14:20AM +0000, M?ns Rullg?rd wrote:
>> >>Diego Biurrun <diego at biurrun.de> writes:
>> >>
>> >>> On Sat, Dec 23, 2006 at 09:08:12PM +0000, M?ns Rullg?rd wrote:
>> >>>> ramiro at lisha.ufsc.br writes:
>> >>>>
>> >>>> > When pthreads are enabled in mingw32, it conflicts with   
>> >>w32threads. This
>> >>>> > patch only enables w32threads if pthreads weren't enabled.
>> >>>>
>> >>>> IMO, win32threads should not be automatically enabled, just like
>> >>>> pthreads are not.
>> >>>
>> >>> I tend to agree, but will the MinGW build work without threading
>> >>> support?
>> >>
>> >>Why should it not?  You just won't get multiple threads when using the
>> >>-threads N flag.  I'd have to test it to be sure though.
>> >
>> >We'll find out, I just changed them to disabled by default.
>> 
>> Ok. I'll only be able to test next year...
>> And what about os/2 and beos threads? Shouldn't they be disabled by  
>> default too with the same rationale?
>
> Probably.  Mans, shall we make all thread support optional?

Threading support should have the same default on all platforms.  I
don't much care whether the default is on or off.

-- 
M?ns Rullg?rd
mru at inprovide.com