[Ffmpeg-devel] Shared libraries install script broken in cvs

[Luca Barbato]

Diego Biurrun wrote:
> On Sat, Dec 17, 2005 at 03:37:02AM +0100, Luca Barbato wrote:
> 
>>Luca Barbato wrote:
>>
>>>Diego Biurrun wrote:
>>>
>>>
>>>>Please send an updated patch if you notice such a thing.
>>>
>>>Hopefully a correct one.
>>
>>yet another revision, that one should fix some problems introduced by 
>>the former.
> 
> 
> Some comments below, the patch is broken.
> 
> 
>>If some osx user/devel would test it I'd clean up the Makefiles and move 
>>the Darwin specific stuff in configure.
> 
> 
> Go ahead, I'll test and commit.
> 
> 
>>-LIBOBJFLAGS=""
>>+LIBOBJFLAGS=""
> 

It was LIBOBJFLAGS='$(PIC)' but is unrelated and would hurt badly 
x86/gcc4 w/out some asm fixes/workarounds.

> 
> This hunk is duplicated...
> 

Ok

> 
>>@@ -339,6 +341,8 @@
>> installstrip=""
>> LDFLAGS="-Wl,-dynamic,-search_paths_first"
>> SLIBSUF=".dylib"
>>+SLIBNAME_WITH_FULLVERSION='$(SLIBPREF)$(NAME).$(LIBVERSION)$(SLIBSUF)'
>>+SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(NAME).$(LIBMAJOR)$(SLIBSUF)'
>> FFSLDFLAGS=-Wl,-bind_at_load
>> ;;
>> MINGW32*)
> 
> 
> What is FULLVERSION for?  It's not used anywhere..
> 

Relic of the past, fixed.

> 
> What are you adding NAME for?  It's never used...
> 

Is used by SLIBNAME_WITH_{VERSION,MAJOR}

I hope this one looks better.

lu

-- 

Luca Barbato

Gentoo/linux Developer		Gentoo/PPC Operational Leader
http://dev.gentoo.org/~lu_zero

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg-soname-symlink.patch
Type: text/x-patch
Size: 4931 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060106/12dd0e88/attachment.bin>