[Ffmpeg-devel] FAAC rate control broken?

[Michael Niedermayer]

Hi

On Mon, Jan 09, 2006 at 01:22:54PM +0100, Luca Abeni wrote:
> Hi Michael,
> 
> On Mon, 2006-01-09 at 11:26 +0100, Michael Niedermayer wrote:
> [...] 
> > > So, just to check if I understood well:
> > > I'll need to add a new field to AVCodecContext, right?
> > 
> > yes
> > 
> > 
> > > Should I add it at the end of the structure (to try to preserve binary
> > 
> > yes
> > 
> > 
> > > compatibility), or can I add it near to the other "audio related"
> > > fields?
> > 
> > no
> > 
> > 
> > > What should I do with LIBAVCODEC_VERSION_INT and LIBAVCODEC_VERSION?
> > > Just increase to 51.1.0, or go to 52.0.0?
> > 
> > no, leave them, users either use AVOption or they cannot expect ABI
> > compatibility
> Ok. So, I think the attached patch does the right thing.
> 
> Note: I hope I used AVOption correctly, but I am not sure (this is the
> first time I play with it).
> Also, I do not know if the other audio encoders supported by ffmpeg
> support this cutoff setting, so I only changed libavcodec/faac.c.

looks good, can be applied

[...]

-- 
Michael