[Ffmpeg-devel] [PATCH] MP4 and MOV encoder support for files > 4GB

[Michael Niedermayer]

Hi

On Fri, Jan 13, 2006 at 10:37:48AM +0100, Dirk Musfeldt wrote:
> Hi,
> 
> this implements the 64 bit chunk offset atom "co64" instead of 32 bit chunk
> offset atom "stco" if necessary. The size of the of the media data atom
> "mdat" is also expressed in 64 bit in this case.
> All uses of url_ftell() are changed to offset_t.

> -    put_be32(pb, curpos - pos); /* rewrite size */
> +    put_be32(pb, (unsigned long)(curpos - pos)); /* rewrite size */

why?


> +    if (j < UINT32_MAX) {
> +        url_fseek(pb, mov->mdat_pos, SEEK_SET);
> +        put_be32(pb, j+8);

j=UINT32_MAX - 1 -> j+8 > UINT32_MAX


this also breaks the regression tests, update them or avoid the breakage

[...]

-- 
Michael