[Ffmpeg-devel] [patch] make SONAME encoding optional

[Diego Biurrun]

On Sat, Jan 14, 2006 at 03:55:58AM +0100, Luca Barbato wrote:
> Diego Biurrun wrote:
> >
> >Which one?  Is the patch from this thread still relevant?
> >
> 
> Updated patch, hopefully that one is less bad
> 
> --- libavcodec/Makefile	13 Jan 2006 00:47:16 -0000	1.222
> +++ libavcodec/Makefile	14 Jan 2006 02:26:42 -0000
> @@ -490,14 +490,22 @@
>  	$(CC) -o $@ $^ $(LIBAVUTIL) -lm
>  
>  ifeq ($(BUILD_SHARED),yes)
> -LIBVERSION=$(LAVCMAJOR)
> +
> +LIBVERSION=$(LAVCVERSION)
> +LIBMAJOR=$(LAVCMAJOR)
> +NAME=avcodec

It's nicer to have these defines together with the others..

> --- libavcodec/libpostproc/Makefile	13 Jan 2006 00:53:36 -0000	1.30
> +++ libavcodec/libpostproc/Makefile	14 Jan 2006 02:27:01 -0000
> @@ -49,12 +49,20 @@
>  
>  install: all
>  ifeq ($(SHARED_PP),yes)
> +LIBVERSION=$(LAVCVERSION)
> +LIBMAJOR=$(LAVCMAJOR)
> +NAME=postproc

These need to be at the top of the Makefile with the rest of the
definitions, they break the build in this spot.

Also, it should be SPPVERSION and SPPMAJOR.

> --- libavformat/Makefile	11 Jan 2006 23:59:59 -0000	1.105
> +++ libavformat/Makefile	14 Jan 2006 02:27:13 -0000
> @@ -80,7 +80,9 @@
>  
>  LIB= $(LIBPREF)avformat$(LIBSUF)
>  ifeq ($(BUILD_SHARED),yes)
> -LIBVERSION=$(LAVFMAJOR)
> +LIBVERSION=$(LAVFVERSION)
> +LIBMAJOR=$(LAVFMAJOR)
> +NAME=avformat
>  SLIBNAME= $(SLIBPREF)avformat$(SLIBSUF)

This SLIBNAME business should go into configure as well.  It's defined
in all the Makefiles...

I won't make you create another iteration, issues fixed and patch
applied...

Diego