[Ffmpeg-devel] [ PATCH ] Fix for: Re: ffmpeg does not build on amd64

[Diego Biurrun]

On Tue, Jan 17, 2006 at 04:13:42PM +0000, Dieter wrote:
> > > >> AMD64
> > > >> FreeBSD 6.0
> > > >> ffmpeg sources from cvs
> 
> Most of this is from
> http://people.FreeBSD.org/~lioux/ffmpeg-devel.tgz
> And there is more in the tar file that I'm not including here.

Why don't the BSD people submit their patches?

> --- configure   2006/01/17 23:49:14     1.1
> +++ configure   2006/01/17 23:49:36
> @@ -130,13 +130,7 @@
>      cpu="x86"
>    ;;
>    x86_64|amd64)
> -    cpu="x86"
> -    canon_arch="`cc -dumpmachine | sed -e 's,\([^-]*\)-.*,\1,'`"
> -    if [ x"$canon_arch" = x"x86_64" -o x"$canon_arch" = x"amd64" ]; then
> -      if [ -z "`echo $CFLAGS | grep -- -m32`"  ]; then
> -        cpu="x86_64"
> -      fi
> -    fi
> +    cpu="x86_64"
>    ;;

This may be appropiate for a FreeBSD port, but surely not for upstream.

> @@ -483,7 +477,7 @@
>    --disable-audio-oss) audio_oss="no"
>    ;;
>    --disable-audio-beos) audio_beos="no"
> -    extralibs="$extralibs -lbe -lmedia"
> +    extralibs="$extralibs"

You are modifying BeOS stuff in a FreeBSD patch?

> @@ -1050,6 +1044,8 @@
>  builtin_vector=no
>  if $cc -msse -o $TMPO $TMPC 2> /dev/null ; then
>    builtin_vector=yes
> +else
> +  builtin_vector=no
>  fi

builtin_vector already gets set three lines above.

This patch is bad and hereby rejected.

Diego