[Ffmpeg-devel] Re: [PATCH] mjpeg interlaced decoding fix

[Baptiste COUDURIER]

Hi

Benjamin Larsson wrote:
> [...]
>
> http://tranquillity.campus.luth.se/~banan/vids/Video_1.mov (144 mb)
> http://tranquillity.campus.luth.se/~banan/vids/mjpeg.mov (5mb cut of former)
> 
> Without the patch ffmpeg segfaults and ffplay plays the first sample
> with half vertical resolution.
> With the patch ffmpeg doesn't segfault and ffplay play both samples with
> correct vertical resolution.
> 
> For backtrace look in ffmpeg-users list. So this patch addresses some bug.
> 
> MvH
> Benjamin Larsson
> 

For what I have traced, the problem resides in difference between
avctx->coded_height and avctx->height.

If picture is interlaced then it seems avctx->coded_height must be * 2
and not avctx->height (what is done currently).

I moved the avcodec_set_dimensions after the check cause it has some
treatment after after setting values.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312